Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle MAX_INT_256 #9511

Merged
merged 9 commits into from
Jun 16, 2021
Merged

fix: Handle MAX_INT_256 #9511

merged 9 commits into from
Jun 16, 2021

Conversation

mankenavenkatesh
Copy link
Contributor

@mankenavenkatesh mankenavenkatesh commented Jun 14, 2021 •
edited
Loading

Change maxBitLen of sdk.Int to handle max Erc20 value.

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mankenavenkatesh
Handle MAX_INT_256
efe4177 
Change maxBitLen of sdk.Int to handle max Erc20 value.
@mankenavenkatesh mankenavenkatesh changed the title Handle MAX_INT_256 fix: Handle MAX_INT_256 Jun 14, 2021
@albertchon albertchon mentioned this pull request Jun 14, 2021
Closed
@mankenavenkatesh mankenavenkatesh marked this pull request as ready for review June 14, 2021 05:20
@zmanian
Copy link
Member

zmanian commented Jun 14, 2021

This is a dependency for Gravity.

SDK.Int was always intended to support up ERC20 max supply.

fedekunze
fedekunze approved these changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a changelog entry?

@codecov
Copy link

codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #9511 (161c111) into master (38d6702) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 161c111 differs from pull request most recent head d50db36. Consider uploading reports for the commit d50db36 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9511   +/-   ##
=======================================
  Coverage   60.58%   60.59%           
=======================================
  Files         589      589           
  Lines       37218    37211    -7     
=======================================
- Hits        22548    22547    -1     
+ Misses      12726    12721    -5     
+ Partials     1944     1943    -1
Impacted Files Coverage Δ
types/decimal.go 70.12% <0.00%> (ø)
types/int.go 72.91% <ø> (ø)
server/config/toml.go 18.18% <0.00%> (ø)
server/config/config.go 41.81% <0.00%> (+0.37%) ⬆️
server/grpc/grpc_web.go 66.66% <0.00%> (+19.99%) ⬆️

fedekunze
fedekunze reviewed Jun 14, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
webmaster128
webmaster128 reviewed Jun 14, 2021
View reviewed changes
types/int_test.go
@@ -69,7 +69,7 @@ func (s *intTestSuite) TestIntPanic() {
s.Require().Panics(func() { i2.Neg().Mul(i2.Neg()) })
s.Require().Panics(func() { i3.Neg().Mul(i3.Neg()) })

// Underflow check
// // Underflow check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, this is not an underflow

Storing values that are too low in an integer variable (e.g., attempting to store −1 in an unsigned integer) is properly referred to as integer overflow, or more broadly, integer wraparound. The term underflow normally refers to floating point numbers only, which is a separate issue.

https://en.wikipedia.org/wiki/Arithmetic_underflow

albertchon and others added 2 commits June 14, 2021 12:47
@albertchon @fedekunze
Update CHANGELOG.md
3f284ea 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@albertchon
Merge branch 'master' into handle_MAX_INT_256
202ee48
aaronc
aaronc approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

robert-zaremba
robert-zaremba approved these changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's create a const for the common expression which is repeated multiple times.

types/decimal.go Outdated
@@ -319,7 +319,7 @@ func (d Dec) QuoRoundUp(d2 Dec) Dec {
quo := new(big.Int).Quo(mul, d2.i)
chopped := chopPrecisionAndRoundUp(quo)

if chopped.BitLen() > 255+DecimalPrecisionBits {
if chopped.BitLen() > (maxBitLen + DecimalPrecisionBits) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a constant for maxBitLen + DecimalPrecisionBits. It's repeated few times.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

types/int.go
@@ -9,7 +9,7 @@ import (
"math/big"
)

const maxBitLen = 255
const maxBitLen = 256
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why previously it was 255 instead of 256?

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 16, 2021
@amaury1093
Copy link
Contributor

Could you allow write access to your branch? So that the mergify bot can merge master and you don't have to constantly do it manually.

@mergify mergify bot merged commit 3841df6 into cosmos:master Jun 16, 2021
@albertchon albertchon deleted the handle_MAX_INT_256 branch June 16, 2021 14:22
zmanian pushed a commit that referenced this pull request Jun 22, 2021
@mankenavenkatesh @zmanian
fix: Handle MAX_INT_256 (#9511)
b7f7c45 
Change maxBitLen of sdk.Int to handle max Erc20 value.

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: #XXXX

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
zmanian pushed a commit that referenced this pull request Jun 23, 2021
@mankenavenkatesh @zmanian
fix: Handle MAX_INT_256 (#9511)
934da87 
Change maxBitLen of sdk.Int to handle max Erc20 value.

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

Closes: #XXXX

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
zmanian pushed a commit that referenced this pull request Jun 23, 2021
@mankenavenkatesh @zmanian
fix: Handle MAX_INT_256 (#9511)
f909859 
Change maxBitLen of sdk.Int to handle max Erc20 value.

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

Closes: #XXXX

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@fedekunze fedekunze mentioned this pull request Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@albertchon albertchon albertchon left review comments

@webmaster128 webmaster128 webmaster128 left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@zmanian zmanian zmanian approved these changes

@aaronc aaronc aaronc approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mankenavenkatesh @zmanian @amaury1093 @aaronc @robert-zaremba @webmaster128 @alexanderbez @albertchon @fedekunze