fix: check store keys length before accessing #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…khita/check-store-keys-length
github-actions
bot
added
C:x/authz
C:x/distribution
Codecov Report
@@ Coverage Diff @@
## master #9639 +/- ##
===========================================
+ Coverage 35.48% 63.41% +27.93%
===========================================
Files 332 571 +239
Lines 32620 37542 +4922
===========================================
+ Hits 11575 23808 +12233
+ Misses 19819 11876 -7943
- Partials 1226 1858 +632
|
…khita/check-store-keys-length
…khita/check-store-keys-length
likhita-809
requested review from
amaury1093,
aleem1314,
anilcse,
atheeshp,
blushi,
cyberbono3 and
ruhatch
alexanderbez
reviewed
Jul 7, 2021
…khita/check-store-keys-length
ruhatch
approved these changes
Jul 7, 2021
…khita/check-store-keys-length
…khita/check-store-keys-length
amaury1093
approved these changes
Jul 8, 2021
…khita/check-store-keys-length
|
…khita/check-store-keys-length
|
With Ru's approval, we got 2, so I'm merging. Thanks @likhita-809 ! |
19 tasks
julienrbrt
pushed a commit
that referenced
this pull request
May 6, 2022
* check store keys length before accessing * check store keys length in all modules * add changelog * refactoring * address review comments * remove commented lines * small fixes * address review comments * fix failing tests * add godocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #8451
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change