-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ADR-43: Aligning on interoperability #9709
Conversation
As discussed with @okwme - we may update a language in this ADR to highlight that x/nft is a base module to be used with other NFT implementations (rather than forked and updated). We can do it in this PR or in a new one. |
cc: @iramiller , @MikeSofaer |
I'm not sure I understand this. Normally I'd expect an interface spec, or some kind of duck typing around something like NFT IBC, not a requirement to implement using a particular piece of code. Shouldn't we be making sure that people who don't use x/nft know how to interoperate with it, rather than demanding everyone use it? |
@Mikerah The interface is already defined by the protobuf definitions in the Msg Service section. The IBC standard is yet to be defined. What we require here, is that other implementations will use |
If what you're saying that x/nft will eventually support an IBC NFT standard, just say that. |
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Visit https://dashboard.github.orijtech.com?pr=9709&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
Co-authored-by: Aaron Craelius <aaron@regen.network>
Description
Following on:
we need to be clear how the NFT token interoperability between modules and chains is achieved.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change