Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add bech32 prefix to authkeeper #9759

Merged
merged 73 commits into from
Aug 25, 2021
Merged

feat!: Add bech32 prefix to authkeeper #9759

Changes from 1 commit
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
030fc2c
first draft
cyberbono3 Jul 20, 2021
556810d
tests pass
cyberbono3 Jul 23, 2021
8ec7872
add DefaultBech32Prefix
cyberbono3 Jul 23, 2021
52ec23d
add comments to auth/query.proto
cyberbono3 Jul 23, 2021
e636781
set sdk.Bech32MainPrefix argument in NewAccountKeeeper()
cyberbono3 Jul 26, 2021
9788e2c
update x/auth/atlas/atlas-v0.39.1.md
cyberbono3 Jul 26, 2021
3fcd6c3
fix TestBech32Prefix
cyberbono3 Jul 26, 2021
64f031f
fix tests
cyberbono3 Jul 26, 2021
befc823
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into cy…
cyberbono3 Jul 26, 2021
413cf7a
gofmt
cyberbono3 Jul 26, 2021
d9be317
update atlas-v0.39.1.md
cyberbono3 Jul 26, 2021
1dd726b
Merge branch 'master' into cyberbono3/add-bech32Prefix-to-authkeeper
cyberbono3 Jul 26, 2021
6a42f00
draft
cyberbono3 Jul 29, 2021
2861b30
Merge branch 'cyberbono3/add-bech32Prefix-to-authkeeper' of https://g…
cyberbono3 Jul 29, 2021
704b006
WIP applying aaron suggestions
cyberbono3 Jul 29, 2021
2459aa0
tests pass
cyberbono3 Aug 2, 2021
54945f1
apply aaron suggestions
cyberbono3 Aug 2, 2021
5992482
update proto comments
cyberbono3 Aug 2, 2021
1734485
update AddressBytesToString signature
cyberbono3 Aug 2, 2021
0cae2b4
add changelog entry for NewAccountKeeper API breaking change
cyberbono3 Aug 3, 2021
743b73c
introduce ConvertAddressStringToBytes and ConvertAddressBytesToString…
cyberbono3 Aug 4, 2021
d602c76
merge master into my branch and resolve conflicts
cyberbono3 Aug 4, 2021
0b5d411
revert unnecessary changes
cyberbono3 Aug 4, 2021
1a552d7
remove unnecessary code
cyberbono3 Aug 4, 2021
366e589
update codec comments
cyberbono3 Aug 4, 2021
ac607ee
address lint issues
cyberbono3 Aug 4, 2021
6cde687
Update CHANGELOG.md
cyberbono3 Aug 5, 2021
4f84700
Update proto/cosmos/auth/v1beta1/query.proto
cyberbono3 Aug 5, 2021
8d223e1
Update proto/cosmos/auth/v1beta1/query.proto
cyberbono3 Aug 5, 2021
9696a52
Update proto/cosmos/auth/v1beta1/query.proto
cyberbono3 Aug 5, 2021
888cf80
Update proto/cosmos/auth/v1beta1/query.proto
cyberbono3 Aug 5, 2021
afb95d5
Update types/address/codec.go
cyberbono3 Aug 5, 2021
21d3090
Update proto/cosmos/auth/v1beta1/query.proto
cyberbono3 Aug 5, 2021
404b31f
Update x/auth/keeper/keeper.go
cyberbono3 Aug 5, 2021
9c5941d
proto-gen
cyberbono3 Aug 5, 2021
7b77ced
apply reviewer comments
cyberbono3 Aug 5, 2021
acf5525
minor fixes
cyberbono3 Aug 5, 2021
c544184
implement VerifyFormat
cyberbono3 Aug 5, 2021
903cd03
Update CHANGELOG.md
cyberbono3 Aug 6, 2021
3afebd7
Update types/address/codec.go
cyberbono3 Aug 6, 2021
9289089
fix grpc query tests
cyberbono3 Aug 9, 2021
ecc5c3e
let VerifyAddressFormat call VerifyFormat
cyberbono3 Aug 9, 2021
570332c
gofmt
cyberbono3 Aug 9, 2021
aea81bc
rename address.Codec methods
cyberbono3 Aug 10, 2021
3d48438
proto gen
cyberbono3 Aug 10, 2021
e6ed444
remove TestCustomAddressVerifier
cyberbono3 Aug 11, 2021
e45fb18
Merge branch 'master' into cyberbono3/add-bech32Prefix-to-authkeeper
cyberbono3 Aug 12, 2021
76f9c8a
revert global GetConfig and TestCustomAddressVerifier
cyberbono3 Aug 15, 2021
35600c5
use sdkerrors in keeper.go
cyberbono3 Aug 17, 2021
e31297b
Update CHANGELOG.md
cyberbono3 Aug 18, 2021
9efcf4a
Update types/address.go
cyberbono3 Aug 18, 2021
60cf6e7
rename address codec interface methods
cyberbono3 Aug 18, 2021
293bdf1
move bech32_codec logic into separate file
cyberbono3 Aug 18, 2021
31bac6d
remove VerifyFormat
cyberbono3 Aug 19, 2021
12106d3
Update types/address/codec.go
cyberbono3 Aug 20, 2021
74cdb60
Update types/address/codec.go
cyberbono3 Aug 20, 2021
49f1858
add ref to VerifyAddressFormat TODO
cyberbono3 Aug 20, 2021
f12c44b
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into cy…
cyberbono3 Aug 20, 2021
3678bce
Update types/address/codec.go
cyberbono3 Aug 24, 2021
53844bb
Update x/auth/keeper/keeper.go
cyberbono3 Aug 24, 2021
b3fb3bd
Fix comments
amaury1093 Aug 24, 2021
131de71
Update x/auth/keeper/keeper.go
cyberbono3 Aug 24, 2021
b32ce72
Update x/auth/keeper/grpc_query_test.go
cyberbono3 Aug 24, 2021
acc6675
Update x/auth/keeper/keeper.go
cyberbono3 Aug 24, 2021
0b27c66
Update x/auth/keeper/keeper.go
cyberbono3 Aug 24, 2021
d4267bf
Update x/auth/keeper/grpc_query_test.go
cyberbono3 Aug 24, 2021
9aae756
Update x/auth/keeper/grpc_query_test.go
cyberbono3 Aug 24, 2021
3d2d5b0
address reviewer comments
cyberbono3 Aug 24, 2021
5d0ba44
Update x/auth/keeper/keeper.go
cyberbono3 Aug 25, 2021
a351a89
Update x/auth/keeper/grpc_query_test.go
cyberbono3 Aug 25, 2021
aa76cbc
Update x/auth/keeper/grpc_query_test.go
cyberbono3 Aug 25, 2021
fb9e5a3
apply reviewer comments
cyberbono3 Aug 25, 2021
4d2a866
Merge branch 'master' into cyberbono3/add-bech32Prefix-to-authkeeper
amaury1093 Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/auth/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ func (ak AccountKeeper) UnmarshalAccount(bz []byte) (types.AccountI, error) {
func (ak AccountKeeper) GetCodec() codec.BinaryCodec { return ak.cdc }

// GetAddressCdc returns address.Codec object used by the keeper
func (ak AccountKeeper) GetAddressCdC() address.Codec { return ak.addressCdC }
func (ak AccountKeeper) GetAddressCdc() address.Codec { return ak.addressCdC }
amaury1093 marked this conversation as resolved.
Show resolved Hide resolved

// add getter for bech32Prefix
func (ak AccountKeeper) GetBech32Prefix() (string, error) {
cyberbono3 marked this conversation as resolved.
Show resolved Hide resolved
Expand Down