Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

x/evm: logger #272

Merged
merged 4 commits into from
Apr 30, 2020
Merged

x/evm: logger #272

merged 4 commits into from
Apr 30, 2020

Conversation

fedekunze
Copy link
Contributor

Description

  • Add tendermint logger for evm module
  • Refactor state transition

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze commented Apr 30, 2020
View reviewed changes
x/evm/types/state_transition.go
// Consume gas from evm execution
// Out of gas check does not need to be done here since it is done within the EVM execution
ctx.WithGasMeter(currentGasMeter).GasMeter().ConsumeGas(gasConsumed, "EVM execution consumption")

err = st.Csdb.SetLogs(*st.THash, logs)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are already set on the handler

fedekunze
fedekunze commented Apr 30, 2020
View reviewed changes
x/evm/types/state_transition.go
}

// ReturnData represents what's returned from a transition
type ReturnData struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to match geth's:

https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/core/state_transition.go#L71-L77

@fedekunze fedekunze marked this pull request as ready for review April 30, 2020 01:59
noot
noot approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@fedekunze fedekunze merged commit d3c802f into development Apr 30, 2020
@noot noot deleted the fedekunze/logger branch May 2, 2020 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noot noot noot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedekunze @noot