Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync up with SDK's latest changes #24

Merged
merged 3 commits into from
May 28, 2019
Merged

Sync up with SDK's latest changes #24

merged 3 commits into from
May 28, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 28, 2019 •
edited
Loading

Continuing from #22

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (rigel/refactor-update@e997673). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             rigel/refactor-update      #24   +/-   ##
========================================================
  Coverage                         ?   56.34%           
========================================================
  Files                            ?        4           
  Lines                            ?      197           
  Branches                         ?        0           
========================================================
  Hits                             ?      111           
  Misses                           ?       83           
  Partials                         ?        3

@alessio alessio changed the base branch from rigel/refactor-update to master May 28, 2019 10:01
@alessio alessio changed the title Refresh go.{mod,sum} Sync up with SDK's latest changes May 28, 2019
@alessio alessio requested review from sabau and fedekunze May 28, 2019 10:01
sabau
sabau reviewed May 28, 2019
View reviewed changes
lcd_test/helpers_test.go
@@ -317,7 +317,7 @@ func InitializeTestLCD(t *testing.T, nValidators int, initAddrs []sdk.AccAddress
stakingDataBz = cdc.MustMarshalJSON(stakingData)
genesisState[staking.ModuleName] = stakingDataBz

genaccountsData := genaccounts.NewGenesisState(accs)
genaccountsData := genaccounts.GenesisState(accs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name comes from the SDK so we can't do much here. But sounds like genaccounts.GenesisState is in fact returning a set of accounts, the name of the function is misleading.

sabau
sabau approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I left a comment but can't be fixed from here

@alessio alessio merged commit 787bd94 into master May 28, 2019
@alessio alessio deleted the alessio/rigel-refactor-upgrade branch May 28, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabau sabau sabau approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @codecov-io @sabau @rigelrozanski