New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get correct type url if protov2 #92

Closed

julienrbrt wants to merge 1 commit into main from julien/protov2-url

Member

julienrbrt commented Sep 29, 2023 •

edited

Loading

ref: cosmos/cosmos-sdk#17913

This brings it in par with https://github.com/cosmos/cosmos-sdk/blob/cae196dc3698ba6b9da2b4f9ffb17169d0aa6f5d/types/tx_msg.go#L98


          feat: get correct type url if protov2

fa499d3

julienrbrt requested a review from a team as a code owner

September 29, 2023 19:53

julienrbrt requested a review from aaronc

September 29, 2023 19:53

Member Author

julienrbrt commented Oct 3, 2023 •

edited

Loading

Closing as I found an alternative in https://github.com/cosmos/cosmos-sdk/pull/17913/files#diff-74fc28df53d002cb71aec0d5fc8b03f46d5981f6962595be010f67f0f87b2f7aR80
Which is more scoped and for sure limits possible side effects of this change.

julienrbrt closed this

julienrbrt deleted the julien/protov2-url branch

October 3, 2023 18:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet