fix: rootKey empty check by len equals 0 (#801)

Co-authored-by: Marko <marbar3778@yahoo.com>
cosmos · Aug 7, 2023 · 06f5be1 · 06f5be1
1 parent 290c94e
commit 06f5be1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@
 
 - [#773](https://github.com/cosmos/iavl/pull/773) Fix memory leak in `Import`.
 - [#795](https://github.com/cosmos/iavl/pull/795) Fix plugin used for buf generate.
+- [#801](https://github.com/cosmos/iavl/pull/801) Fix rootKey empty check by len equals 0.
 
 ### Breaking Changes
 

diff --git a/iterator.go b/iterator.go
@@ -269,7 +269,7 @@ type NodeIterator struct {
 
 // NewNodeIterator returns a new NodeIterator to traverse the tree of the root node.
 func NewNodeIterator(rootKey []byte, ndb *nodeDB) (*NodeIterator, error) {
-	if rootKey == nil {
+	if len(rootKey) == 0 {
 		return &NodeIterator{
 			nodesToVisit: []*Node{},
 			ndb:          ndb,

diff --git a/iterator_test.go b/iterator_test.go
@@ -366,4 +366,8 @@ func TestNodeIterator_WithEmptyRoot(t *testing.T) {
 	itr, err := NewNodeIterator(nil, newNodeDB(dbm.NewMemDB(), 0, nil, log.NewNopLogger()))
 	require.NoError(t, err)
 	require.False(t, itr.Valid())
+
+	itr, err = NewNodeIterator([]byte{}, newNodeDB(dbm.NewMemDB(), 0, nil, log.NewNopLogger()))
+	require.NoError(t, err)
+	require.False(t, itr.Valid())
 }