Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleveldb, boltdb, rocksdb and badgerdb tests in CI #469

Closed
4 tasks
p0mvn opened this issue Feb 16, 2022 · 3 comments
Closed
4 tasks

Fix cleveldb, boltdb, rocksdb and badgerdb tests in CI #469

p0mvn opened this issue Feb 16, 2022 · 3 comments

Comments

@p0mvn
Copy link
Member

p0mvn commented Feb 16, 2022

Background

We refactored benchmarks to test all databases in #465 . However, the CI is failing in bencher: https://dashboard.bencher.orijtech.com/benchmark/adc2a152a52245579ef92af91f4f0f74

In #468 we commented out all databases but memdb and goleveldb to allow bencher to pass.

From the initial investigation, the failure might be due to these additional databases requiring extra setup:
https://github.com/cosmos/iavl/blob/fe24be8d8d97a95c588554299eb045dea116a8a9/benchmarks/setup/INSTALL_ROOT.sh

However, more investigation is needed to determine the true source

Acceptance Criteria

  • the root cause of bencher failures is found
  • a PR with the fix is created
  • bencher passes for all databases currently commented out in bench_test.go
  • no time out observed
@tac0turtle
Copy link
Member

@faddat I think you did this work?

@faddat
Copy link
Contributor

faddat commented Apr 20, 2022

I did, but we are held up on a merge.

Here's what I'll do to resolve:

Close this PR:
#466

Finish implemeting this issue:
cosmos/cosmos-sdk#11688

Make this repository depend on that docker image.

Also, if there are no known usages of iavl outside of the cosmos-sdk, I want to recommend that we move this into cosmos/cosmos-sdk

@tac0turtle
Copy link
Member

Closing as we are migrating to cosmos-db and removed badger and bolt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants