Update docker.yml and Dockerfile, fix ci #466
Conversation
Use github container registry
Dockerfile
Outdated
|
|
||
| WORKDIR /iavl | ||
| # This docker image is designed to be used in CI for benchmarks and also by developers wanting an environment that always has the lastest rocksdb and cleveldb. | ||
| FROM faddat/archlinux |
There was a problem hiding this comment.
how about using one of the official arch or alpine linux distros?
There was a problem hiding this comment.
hey sure thing, but ah, that means alpine and thus musl.
I maintain that image because Arch isn't multiarch by default. If we then search for distros with really rigorously up to date rolling release package management, we come up emptdy. What do you think?
That image is built here:
https://github.com/faddat/archlinux-docker/runs/5964553569?check_suite_focus=true
Here's how it works:
it makes amd64
it makes arm64
it combines them into the same manifest and then pushes to docker hub daily.
Since few use musl for real, using alpine as build distro invites pain in the form of build environments that don't match runtime environments.
If popularity / adoption / usage matters, I do think it is the leading multiarch arch linux image on docker hub.
| context: . | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: true | ||
| tags: ghcr.io/${{ github.repository_owner }}/iavl:latest |
There was a problem hiding this comment.
love this!! we should migrate everything we have to this
There was a problem hiding this comment.
so, ok-- this is a package deal with the above docker image, at least in my experience the multiarch stuff. Let me see what I can do.
|
we removed this docker file |
Use github container registry