Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api to save ChangeSet #695

Merged
merged 4 commits into from
Mar 2, 2023
Merged

feat: add api to save ChangeSet #695

merged 4 commits into from
Mar 2, 2023

Conversation

cool-develope
Copy link
Collaborator

ref: #675

To migrate the original tree to the new node-key, it needs to sync the specific version in the new format

@cool-develope cool-develope requested a review from a team as a code owner February 28, 2023 13:53
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you use another api to pull the change sets out and this would be writing?

@cool-develope
Copy link
Collaborator Author

would you use another api to pull the change sets out and this would be writing?

sure, since we already have the fetching api here (

func (t *ImmutableTree) TraverseStateChanges(startVersion, endVersion int64, fn func(version int64, changeSet *ChangeSet) error) error {
)

@tac0turtle tac0turtle merged commit de1532f into master Mar 2, 2023
@tac0turtle tac0turtle deleted the 675/save_changeset branch March 2, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants