-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove cosmos-db as a dep #955
Conversation
Warning Review failedThe pull request is closed. WalkthroughThe update primarily modernizes dependencies and refines database interactions within the project. Key changes include upgrading Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
panic(err) | ||
} | ||
if err != nil { | ||
panic(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, lgtm! small concern of RocksDB users won't be compatible
what do you mean? since db is passed from above would it not work out of the box? |
no, I'd like to add the small godoc or description of how to use |
in the cmd go.mod right? |
@Mergifyio backport release/v1.2.x |
✅ Backports have been created
|
(cherry picked from commit e063edd) # Conflicts: # benchmarks/bench_test.go # benchmarks/cosmos-exim/main.go # cmd/go.mod # cmd/go.sum # db/README.md # diff_test.go # docs/proof/proof.md # go.mod # go.sum # immutable_tree.go # iterator_test.go # mutable_tree.go # nodedb.go # testutils_test.go # tree_test.go
Summary by CodeRabbit
New Features
GoLevelDB
implementation for key-value store operations.PrefixDB
struct for namespacingKVStores
.Bug Fixes
Format
method of theHexBytes
type.Refactor
corestore
instead ofdbm
for database operations.db.Batch
withstore.Batch
in relevant functions and structs.Documentation
Chores
golangci_version
in theMakefile
tov1.59.1
.go.mod
for improved compatibility and performance.