Skip to content

Commit

Permalink
chore: explicitly set channel version for non-incentivized ica tests (#…
Browse files Browse the repository at this point in the history
…2036)

* explicitly set channel version for non-incentivized ica tests

* chore: updating tag in manual e2e icad workflow

Co-authored-by: Cian Hatton <cianhatton@gmail.com>
  • Loading branch information
damiannolan and chatton authored Aug 19, 2022
1 parent 995b647 commit 28c1520
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/e2e-manual-icad.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
- master
- v0.3.2
- v0.2.2
- v0.1.2
- v0.1.3
chain-b-tag:
default: master
description: 'The tag to use for chain B'
Expand All @@ -35,7 +35,7 @@ on:
- master
- v0.3.2
- v0.2.2
- v0.1.2
- v0.1.3
relayer-tag:
description: 'The tag to use for the relayer'
required: true
Expand Down
5 changes: 3 additions & 2 deletions e2e/interchain_accounts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"github.com/cosmos/ibc-go/e2e/testsuite"
"github.com/cosmos/ibc-go/e2e/testvalues"

icatypes "github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/types"
feetypes "github.com/cosmos/ibc-go/v5/modules/apps/29-fee/types"
ibctesting "github.com/cosmos/ibc-go/v5/testing"
)
Expand Down Expand Up @@ -59,7 +60,7 @@ func (s *InterchainAccountsTestSuite) TestMsgSubmitTx_SuccessfulTransfer() {
var hostAccount string

t.Run("register interchain account", func(t *testing.T) {
version := "" // allow app to handle the version as appropriate.
version := icatypes.NewDefaultMetadataString(ibctesting.FirstConnectionID, ibctesting.FirstConnectionID)
msgRegisterAccount := intertxtypes.NewMsgRegisterAccount(controllerAccount.Bech32Address(chainA.Config().Bech32Prefix), ibctesting.FirstConnectionID, version)
err := s.RegisterInterchainAccount(ctx, chainA, controllerAccount, msgRegisterAccount)
s.Require().NoError(err)
Expand Down Expand Up @@ -153,7 +154,7 @@ func (s *InterchainAccountsTestSuite) TestMsgSubmitTx_FailedTransfer_Insufficien
var hostAccount string

t.Run("register interchain account", func(t *testing.T) {
version := "" // allow app to handle the version as appropriate.
version := icatypes.NewDefaultMetadataString(ibctesting.FirstConnectionID, ibctesting.FirstConnectionID)
msgRegisterAccount := intertxtypes.NewMsgRegisterAccount(controllerAccount.Bech32Address(chainA.Config().Bech32Prefix), ibctesting.FirstConnectionID, version)
err := s.RegisterInterchainAccount(ctx, chainA, controllerAccount, msgRegisterAccount)
s.Require().NoError(err)
Expand Down

0 comments on commit 28c1520

Please sign in to comment.