Merge branch 'main' into chore/trim_event_emissions

cosmos · Mar 27, 2024 · 8aa4e02 · 8aa4e02
2 parents 26fc764 + 2555a7c
commit 8aa4e02
Show file tree

Hide file tree

Showing 350 changed files with 6,163 additions and 13,325 deletions.
diff --git a/.codecov.yml b/.codecov.yml
diff --git a/.coderabbit.yml b/.coderabbit.yml
@@ -0,0 +1,35 @@
+language: "en"
+early_access: false
+reviews:
+    request_changes_workflow: false
+    high_level_summary: true
+    poem: false
+    review_status: true
+    collapse_walkthrough: true
+    path_filters:
+      - "!**/*.pb.go"
+      - "!**/*.pb.gw.go"
+      - "!**/*.mod"
+      - "!**/*.sum"
+    path_instructions:
+        - path: "**/*.go"
+          instructions: "Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations."
+        - path: "e2e/**/*"
+          instructions: |
+              "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
+        - path: "**/*_test.go"
+          instructions: |
+              "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
+        - path: "**/*.md"
+          instructions: |
+              "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
+    auto_review:
+        enabled: true
+        ignore_title_keywords:
+            - "WIP"
+            - "DO NOT MERGE"
+        drafts: false
+        base_branches:
+            - "main"
+chat:
+    auto_reply: true
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -11,40 +11,40 @@
 
 # CODEOWNERS for the CODEOWNER file
 
-/.github/CODEOWNERS @colin-axner @AdityaSripal @crodriguezvega @damiannolan
+/.github/CODEOWNERS @colin-axner @AdityaSripal @crodriguezvega @damiannolan @chatton
 
 # CODEOWNERS for the core IBC module
 
-/modules/core/ @colin-axner @AdityaSripal @damiannolan
-/proto/ibc/core/ @colin-axner @AdityaSripal @damiannolan
+/modules/core/ @colin-axner @AdityaSripal @damiannolan @chatton
+/proto/ibc/core/ @colin-axner @AdityaSripal @damiannolan @chatton
 
 # CODEOWNERS for the light-clients
 
-/modules/light-clients/ @colin-axner @AdityaSripal @damiannolan
-/proto/ibc/lightclients/ @colin-axner @AdityaSripal @damiannolan
+/modules/light-clients/ @colin-axner @AdityaSripal @damiannolan @chatton
+/proto/ibc/lightclients/ @colin-axner @AdityaSripal @damiannolan @chatton
 
 # CODEOWNERS for 08-wasm light client module
 
 /modules/light-clients/08-wasm/ @colin-axner @AdityaSripal @damiannolan @charleenfei @chatton @DimitrisJim @srdtrk @crodriguezvega
 
 # CODEOWNERS for ICS 20
 
-/modules/apps/transfer/ @colin-axner @AdityaSripal @damiannolan
-/proto/ibc/applications/transfer/ @colin-axner @AdityaSripal @damiannolan
+/modules/apps/transfer/ @colin-axner @AdityaSripal @damiannolan @chatton
+/proto/ibc/applications/transfer/ @colin-axner @AdityaSripal @damiannolan @chatton
 
 # CODEOWNERS for interchain-accounts module
 
-/modules/apps/27-interchain-accounts/ @colin-axner @AdityaSripal @damiannolan
-/proto/ibc/applications/interchain_accounts/ @colin-axner @AdityaSripal @damiannolan
+/modules/apps/27-interchain-accounts/ @colin-axner @AdityaSripal @damiannolan @chatton
+/proto/ibc/applications/interchain_accounts/ @colin-axner @AdityaSripal @damiannolan @chatton
 
 # CODEOWNERS for fee module
 
-/modules/apps/29-fee/ @AdityaSripal @charleenfei @colin-axner @damiannolan 
-/proto/ibc/applications/fee/ @AdityaSripal @charleenfei @colin-axner @damiannolan
+/modules/apps/29-fee/ @AdityaSripal @charleenfei @colin-axner @damiannolan @chatton
+/proto/ibc/applications/fee/ @AdityaSripal @charleenfei @colin-axner @damiannolan @chatton
 
 # CODEOWNERS for callbacks middleware
 
-/modules/apps/callbacks/ @colin-axner @AdityaSripal @damiannolan @srdtrk
+/modules/apps/callbacks/ @colin-axner @AdityaSripal @damiannolan @srdtrk @chatton
 
 # CODEOWNERS for docs
 

diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md
@@ -22,6 +22,10 @@ What problems may be addressed by introducing this feature?
 What benefits does the ibc-go stand to gain by including this feature?
 Are there any disadvantages of including this feature? -->
 
+## Use cases
+
+<!-- What use cases will be enabled by the introduction of this feature? -->
+
 ## Proposal
 
 <!-- Detailed description of requirements of implementation -->

diff --git a/.github/ISSUE_TEMPLATE/release-tracker.md b/.github/ISSUE_TEMPLATE/release-tracker.md
@@ -58,6 +58,7 @@ versions of ibc-go to guarantee that no regression is introduced -->
   - Remove any tags that might not be recommended anymore.
 - [ ] Update the list of [supported release lines in README.md](https://github.com/cosmos/ibc-go#releases), if necessary.
 - [ ] Update docs site:
+  - [ ] Update permalinks with links of the released tag.
   - [ ] If the release is occurring on the main branch, on the latest version, then run `npm run docusaurus docs:version vX.Y.Z` in the `docs/` directory. (where `X.Y.Z` is the new version number)
   - [ ] If the release is occurring on an older release branch, then make a PR to the main branch called `docs: new release vX.Y.Z` doing the following:
     - [ ] Update the content of the docs found in `docs/versioned_docs/version-vx.y.z` if needed. (where `x.y.z` is the previous version number)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -12,17 +12,10 @@ are the most critical to review.
 
 closes: #XXXX
 
+<!-- Please refer to the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages in ibc-go.
 
-### Commit Message / Changelog Entry
+This repository uses [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/).
 
-```text
-type: commit message
-```
-
-see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples)
-
-
-<!--
 Example commit messages:
 
 fix: skip emission of unpopulated memo field in ics20
@@ -42,11 +35,12 @@ checked off. If any of the checklist items are not applicable, please leave them
 write a little note why.
 
 - [ ] Targeted PR against the correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)).
-- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
+- [ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
 - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/build/building-modules/11-structure.md) and [Go style guide](../docs/dev/go-style-guide.md).
 - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package).
-- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`).
+- [ ] Updated relevant documentation (`docs/`).
 - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
-- [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review.
-- [ ] Re-reviewed `Files changed` in the Github PR explorer.
-- [ ] Review `Codecov Report` in the comment section below once CI passes.
+- [ ] Provide a [conventional commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to follow the repository standards.
+- [ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
+- [ ] Re-reviewed `Files changed` in the GitHub PR explorer.
+- [ ] Review `SonarCloud Report` in the comment section below once CI passes.
diff --git a/.github/workflows/build-callbacks-simd-image-from-tag.yml b/.github/workflows/build-callbacks-simd-image-from-tag.yml
@@ -22,7 +22,7 @@ jobs:
             ref: "${{ env.GIT_TAG }}"
             fetch-depth: 0
          - name: Log in to the Container registry
-           uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d
+           uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20
            with:
               registry: ${{ env.REGISTRY }}
               username: ${{ github.actor }}

diff --git a/.github/workflows/build-simd-image-from-tag.yml b/.github/workflows/build-simd-image-from-tag.yml
@@ -26,7 +26,7 @@ jobs:
             ref: "${{ env.GIT_TAG }}"
             fetch-depth: 0
          - name: Log in to the Container registry
-           uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d
+           uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20
            with:
               registry: ${{ env.REGISTRY }}
               username: ${{ github.actor }}

diff --git a/.github/workflows/build-wasm-simd-image-from-tag.yml b/.github/workflows/build-wasm-simd-image-from-tag.yml
@@ -27,7 +27,7 @@ jobs:
          - name: Install dependencies
            run: make python-install-deps
          - name: Log in to the Container registry
-           uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d
+           uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20
            with:
               registry: ${{ env.REGISTRY }}
               username: ${{ github.actor }}

diff --git a/.github/workflows/callbacks.yml b/.github/workflows/callbacks.yml
@@ -48,3 +48,11 @@ jobs:
         run: |
           cd modules/apps/callbacks
           go test -v -mod=readonly ./...
+      - name: sonarcloud
+        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
+        uses: SonarSource/sonarcloud-github-action@v2.1.1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          projectBaseDir: modules/apps/callbacks/
diff --git a/.github/workflows/capability.yml b/.github/workflows/capability.yml
@@ -24,6 +24,7 @@ jobs:
           GOARCH=${{ matrix.go-arch }} go build ./...
 
   tests:
+    if: github.event.pull_request.head.repo.full_name == github.repository && github.actor != 'dependabot[bot]'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -34,3 +35,11 @@ jobs:
         run: |
           cd modules/capability
           go test -v -mod=readonly ./...
+      - name: sonarcloud
+        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
+        uses: SonarSource/sonarcloud-github-action@v2.1.1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          projectBaseDir: modules/capability/
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -28,7 +28,7 @@ jobs:
         images: ${{ env.REGISTRY }}/cosmos/${{ env.IMAGE_NAME }}
 
     - name: Build Docker image
-      uses: docker/build-push-action@4a13e500e55cf31b7a5d59a38ab2040ab0f42f56
+      uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0
       with:
         context: .
         tags: ${{ steps.meta.outputs.tags }}
@@ -39,14 +39,14 @@ jobs:
       run: |
         docker run --rm ${{ steps.meta.outputs.tags }}
     - name: Log in to the Container registry
-      uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d
+      uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20
       with:
         registry: ${{ env.REGISTRY }}
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
 
     - name: Push Docker image
-      uses: docker/build-push-action@4a13e500e55cf31b7a5d59a38ab2040ab0f42f56
+      uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0
       with:
         context: .
         push: true

diff --git a/.github/workflows/e2e-compatibility-unreleased.yaml b/.github/workflows/e2e-compatibility-unreleased.yaml
@@ -22,7 +22,7 @@ jobs:
           ref: "${{ matrix.release-branch }}"
           fetch-depth: 0
       - name: Log in to the Container registry
-        uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d
+        uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}

diff --git a/.github/workflows/e2e-compatibility.yaml b/.github/workflows/e2e-compatibility.yaml
@@ -56,7 +56,7 @@ jobs:
           fetch-depth: 0
       - name: Log in to the Container registry
         if: env.RELEASE_BRANCH == matrix.release-branch
-        uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d
+        uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}

diff --git a/.github/workflows/e2e-test-workflow-call.yml b/.github/workflows/e2e-test-workflow-call.yml
@@ -112,7 +112,7 @@ jobs:
         if: ${{ inputs.build-and-push-docker-image }}
       - name: Log in to the Container registry
         if: ${{ inputs.build-and-push-docker-image }}
-        uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d
+        uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
@@ -127,7 +127,7 @@ jobs:
 
       - name: Build and push Docker image
         if: ${{ inputs.build-and-push-docker-image }}
-        uses: docker/build-push-action@4a13e500e55cf31b7a5d59a38ab2040ab0f42f56
+        uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0
         with:
           context: .
           push: true
@@ -159,7 +159,7 @@ jobs:
 
       - name: Log in to the Container registry
         if: ${{ inputs.build-and-push-docker-image-wasm }}
-        uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d
+        uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
@@ -174,7 +174,7 @@ jobs:
 
       - name: Build and push Docker image
         if: ${{ inputs.build-and-push-docker-image-wasm }}
-        uses: docker/build-push-action@4a13e500e55cf31b7a5d59a38ab2040ab0f42f56
+        uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0
         with:
           context: .
           push: true

diff --git a/.github/workflows/e2emodule.yml b/.github/workflows/e2emodule.yml
@@ -0,0 +1,33 @@
+name: E2E Unit tests/Lint.
+# This workflow runs when a PR is opened that targets code that is part of the e2e module.
+on:
+  pull_request:
+    paths:
+      - '.github/workflows/e2emodule.yml'
+      - 'e2e/**'
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/setup-go@v5
+        with:
+          go-version: '1.21'
+      - uses: actions/checkout@v4
+      - uses: golangci/golangci-lint-action@v4.0.0
+        with:
+          version: v1.54.2
+          args: --timeout 5m
+          working-directory: e2e/
+
+  tests:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: '1.21'
+      - name: Go Test
+        run: |
+          cd e2e
+          go test -v -mod=readonly ./... -tags='test_e2e'
diff --git a/.github/workflows/markdown-lint.yml b/.github/workflows/markdown-lint.yml
@@ -13,7 +13,7 @@ jobs:
     - uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    - uses: tj-actions/changed-files@v42
+    - uses: tj-actions/changed-files@v43
       id: changed-files
       with:
         files: '**/*.md'

diff --git a/.github/workflows/proto-registry.yml b/.github/workflows/proto-registry.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: bufbuild/buf-setup-action@v1.29.0
+      - uses: bufbuild/buf-setup-action@v1.30.0
       - uses: bufbuild/buf-push-action@v1
         with:
           input: "proto"