Skip to content

Commit

Permalink
rename portid and port prefix for interchain accounts submodules (#779)
Browse files Browse the repository at this point in the history
## Description

I decided to remove the `-` from the port ID (`ica-host`) and prefix (`ica-controller`) and just make it one word (`icahost` and `icacontroller`), just in case we decide to do some parsing based on a `-` delimiter in the future.

closes: #778 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
  • Loading branch information
crodriguezvega committed Feb 2, 2022
1 parent f7bb142 commit 8cba0eb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions modules/apps/27-interchain-accounts/types/keys.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ const (
ModuleName = "interchainaccounts"

// PortID is the default port id that the interchain accounts host submodule binds to
PortID = "interchain-account"
PortID = "icahost"

// PortPrefix is the default port prefix that the interchain accounts controller submodule binds to
PortPrefix = "ics27-"
PortPrefix = "icacontroller-"

// Version defines the current version for interchain accounts
Version = "ics27-1"
Expand Down

0 comments on commit 8cba0eb

Please sign in to comment.