Bump golangci for callbacks, fix complaints from unparam. (#4417)

cosmos · Aug 22, 2023 · b25c065 · b25c065
1 parent 97a5a59
commit b25c065
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/callbacks.yml b/.github/workflows/callbacks.yml
@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: golangci/golangci-lint-action@v3.7.0
         with:
-          version: v1.53.3
+          version: v1.54.2
           args: --timeout 5m
           working-directory: modules/apps/callbacks
 

diff --git a/modules/apps/callbacks/ibc_middleware_test.go b/modules/apps/callbacks/ibc_middleware_test.go
@@ -774,7 +774,7 @@ func (s *CallbacksTestSuite) TestProcessCallback() {
 			func() {
 				executionGas := callbackData.ExecutionGasLimit
 				expGasConsumed = executionGas
-				callbackExecutor = func(cachedCtx sdk.Context) error {
+				callbackExecutor = func(cachedCtx sdk.Context) error { //nolint:unparam
 					cachedCtx.GasMeter().ConsumeGas(expGasConsumed+1, "callbackExecutor gas consumption")
 					return nil
 				}
@@ -811,7 +811,7 @@ func (s *CallbacksTestSuite) TestProcessCallback() {
 				executionGas := callbackData.ExecutionGasLimit
 				callbackData.CommitGasLimit = executionGas + 1
 				expGasConsumed = executionGas
-				callbackExecutor = func(cachedCtx sdk.Context) error {
+				callbackExecutor = func(cachedCtx sdk.Context) error { //nolint:unparam
 					cachedCtx.GasMeter().ConsumeGas(executionGas+1, "callbackExecutor oog panic")
 					return nil
 				}
@@ -843,7 +843,7 @@ func (s *CallbacksTestSuite) TestProcessCallback() {
 			ctx = s.chainB.GetContext()
 
 			// set a callback executor that will always succeed after consuming expGasConsumed
-			callbackExecutor = func(cachedCtx sdk.Context) error {
+			callbackExecutor = func(cachedCtx sdk.Context) error { //nolint:unparam
 				cachedCtx.GasMeter().ConsumeGas(expGasConsumed, "callbackExecutor gas consumption")
 				return nil
 			}