Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support validator set updates in testing package #1012

Closed
AdityaSripal opened this issue Feb 25, 2022 · 0 comments · Fixed by #1003
Closed

Support validator set updates in testing package #1012

AdityaSripal opened this issue Feb 25, 2022 · 0 comments · Fixed by #1003
Labels
testing Testing package and unit/integration tests

Comments

@AdityaSripal
Copy link
Member

Currently the testing suite will fail on UpdateClient because the testing suite does not call Endblock and validator updates are not properly reflected in the updateclient headers.

The chain simulation must call EndBlock, test headers must be allowed to have next vals different from vals, and validator updates need to correctly get simulated in the update headers
@AdityaSripal AdityaSripal added the testing Testing package and unit/integration tests label Feb 25, 2022
@AdityaSripal AdityaSripal changed the title All validator set updates in testing package Support validator set updates in testing package Feb 28, 2022
@AdityaSripal AdityaSripal mentioned this issue Feb 28, 2022
Merged
9 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@gupadhyaya
adding a table to README showing rollkit compatibility (cosmos#1012)
b02839e 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing package and unit/integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow testing to update ValidatorSet cosmos/ibc-go
1 participant
@AdityaSripal