Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marshalling error on logger packet.GetSequence #1161

Closed
3 tasks
fedekunze opened this issue Mar 22, 2022 · 1 comment · Fixed by #1160
Closed
3 tasks

Marshalling error on logger packet.GetSequence #1161

fedekunze opened this issue Mar 22, 2022 · 1 comment · Fixed by #1160

Comments

@fedekunze
Copy link
Contributor

Summary of Bug

The logger throws a marshaling error when trying to convert the sequence (uint64) to string.

evmosd         | 5:18PM INF indexed block height=81 module=txindex server=node
evmosd         | 5:18PM INF client state updated client-id=07-tendermint-0 height=1-169 module=x/ibc/client
evmosd         | 5:18PM INF packet received dst_channel=channel-0 dst_port=transfer module=x/ibc/channel sequence=1 src_channel=channel-0 src_port=transfer
evmosd         | 5:18PM INF minted coins from module account amount=100ibc/ED07A3391A112B175915CD8FAF43A2DA8E4790EDE12566649D0C2F97716B8518 from=transfer module=x/bank
evmosd         | 5:18PM INF acknowledgement written dst_channel=channel-0 dst_port=transfer module=x/ibc/channel sequence="marshaling error: json: unsupported type: func() uint64" src_channel=channel-0 src_port=transfer

You can see below that the logger converts the types to a string:

https://github.com/cosmos/cosmos-sdk/blob/5e9656f363a0b8e1e00a58aaeee3c0a8c1e1561b/server/logger.go#L44-L55

Version

v3.0.0

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@fedekunze
Copy link
Contributor Author

I see the issue was fixed here: #1130

@fedekunze fedekunze mentioned this issue Mar 22, 2022
Merged
9 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Manav-Aggarwal
adr-update: Update ADR 009 (cosmos#1161)
1d05cbe 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes: cosmos#989 
<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

imp: improve Logger performance cosmos/ibc-go
1 participant
@fedekunze