Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VerifyMembership/VerifyNonMembership to 06-solomachine #1292

Closed
3 tasks
Tracked by #1293
, #1294 ,  #1295 ,  #1296
...
colin-axner opened this issue Apr 25, 2022 · 2 comments
Closed
3 tasks
Tracked by #1293
, #1294 ,  #1295 ,  #1296
...

Add VerifyMembership/VerifyNonMembership to 06-solomachine #1292

colin-axner opened this issue Apr 25, 2022 · 2 comments
Assignees
@damiannolan
Labels
06-solomachine
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

sub issue of #1145

Both functions only need to support existing well defined paths. see comment

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
This was referenced Apr 25, 2022
Closed
Closed
Closed
Closed
@damiannolan
Copy link
Member

I'm not 100% sure on whats required for this based on the comment linked.
@colin-axner could we sync on this whenever we can get together. For now I'm moving forward with #1293

@damiannolan damiannolan mentioned this issue Jul 18, 2022
Merged
9 tasks
@crodriguezvega
Copy link
Contributor

Closed by #1687

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Manav-Aggarwal
Make error message verbs/tense consistent (cosmos#1292)
cc657b0 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Closes cosmos#1232

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

**Chores:**
- Updated error messages in `GetNodeKey` function in `node/crypto.go`
for better clarity.
- Enhanced error descriptions in several functions within `node/full.go`
to provide more detailed information.
- Improved error messages in `newLightNode` function in `node/light.go`
to offer more specific information about startup and initialization
errors.

These changes aim to improve the clarity of error messages, aiding in
quicker identification and resolution of issues. No functionality or
logic has been altered.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
06-solomachine
Projects
ibc-go
Archived in project
Milestone
02-client refactor beta
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @colin-axner