Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly set channel version for non-incentivized ica tests #2036

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Aug 18, 2022

Description

Passing test here

Note: the incentived channel test is expected to fail as this particular test is is using ibc-go v3.2.0


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice job finding the issue! 🥇

@damiannolan damiannolan marked this pull request as ready for review August 19, 2022 09:05
@damiannolan damiannolan merged commit 28c1520 into main Aug 19, 2022
@damiannolan damiannolan deleted the damian/explicit-version-string branch August 19, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants