Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase IBC init genesis validation on identifiers #23

Open
4 tasks
colin-axner opened this issue Dec 3, 2020 · 2 comments
Open
4 tasks

Increase IBC init genesis validation on identifiers #23

colin-axner opened this issue Dec 3, 2020 · 2 comments
Labels
testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

Summary

In InitGenesis for each type of identifier (client, connection, channel) we should determine the max sequence in the provided identifiers and ensure that the next sequence used in creating identifiers is greater than the max sequence.

Edit: this has been fixed

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner
Copy link
Contributor Author

colin-axner commented Dec 4, 2020 •
edited
Loading

We should probably also check that the sub identifiers (clientID in a connection, connectionID in a channel) do exist

Edit: this still needs to be done

@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
@colin-axner
Copy link
Contributor Author

We need to increase genesis testing! ref #200

@colin-axner colin-axner added this to the 1.1.0 milestone May 28, 2021
@colin-axner colin-axner added the testing Testing package and unit/integration tests label May 28, 2021
@crodriguezvega crodriguezvega modified the milestones: 1.1.0, vNext Sep 17, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #23 from sikkatech/genesis_tests
eb78f8c 
Add genesis tests
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jhernandezb
Merge PR #23: Improve run for loop logic and fix lint issues
a4a2aba 
* Improved run loop

* Fixed lint issues
@crodriguezvega crodriguezvega removed this from the Q2-2022-backlog milestone Mar 31, 2022
faddat pushed a commit to faddat/ibc-go that referenced this issue Mar 29, 2023
@misko9
Merge pull request cosmos#23 from notional-labs/lint-7one
dc64743 
lint 7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing package and unit/integration tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner