Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC Tendermint minor fixes #33

Closed
1 of 12 tasks
colin-axner opened this issue Nov 9, 2020 · 1 comment
Closed
1 of 12 tasks

IBC Tendermint minor fixes #33

colin-axner opened this issue Nov 9, 2020 · 1 comment

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Nov 9, 2020 •
edited
Loading

Summary

  • Add comment about optional chain ID format and default version number in chainID basic validation
  • Regex for upgrade path validation
  • Try to deduplicate code in all the VerifyXYZ functions
  • Check FrozenHeight LTE instead of !GT
  • Move basic clientState checks to top of VerifyXYZ functions (less intensive checks first)
  • Ditto for basic consensusState checks
  • Remove redundant check in upgradeClient (upgrade path empty string check and maybe more)
  • Remove redundant checks in tendermint update/misbehaviour functions in comparison to 02-client checks and msg.validate basic

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #33 from cosmwasm/opaque-dispatch
2de9a68 
Opaque dispatch
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jackzampolin
Merge PR #33: update to latest sdk
f3a302d
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Describe peer discovery in ADR (cosmos#33)
e7de747
@coderabbitai coderabbitai bot mentioned this issue Apr 10, 2024
Merged
10 tasks
@colin-axner
Copy link
Contributor Author

Closing as stale. It's been a long time since this issue was opened!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colin-axner