Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt connection e2e params test to use gov v1 message #3704

Closed
1 task
Tracked by #2010
crodriguezvega opened this issue May 31, 2023 · 1 comment
Closed
1 task
Tracked by #2010

adapt connection e2e params test to use gov v1 message #3704

crodriguezvega opened this issue May 31, 2023 · 1 comment
Assignees
@DimitrisJim
Labels
03-connection e2e
Milestone
v8.0.0

Comments

@crodriguezvega
Copy link
Contributor

Part of #2010

Pre-requisite:

Adjust TestMaxExpectedTimePerBlockParam to use gov v1 message when the version of the chain supports it (keep using legacy params for versions that don't support gov v1).

Alternatively we could also not test legacy params anymore and test only with gov v1. Open to the opinion of others.
@crodriguezvega crodriguezvega mentioned this issue May 31, 2023
Closed
12 tasks
@crodriguezvega crodriguezvega added this to the v8.0.0 milestone May 31, 2023
@DimitrisJim DimitrisJim self-assigned this May 31, 2023
@DimitrisJim DimitrisJim moved this to In review in ibc-go May 31, 2023
@DimitrisJim DimitrisJim moved this from In review to Done in ibc-go Jun 2, 2023
@DimitrisJim
Copy link
Contributor

Done in #3650

@github-project-automation github-project-automation bot moved this from Done to Todo in ibc-go Jun 2, 2023
@DimitrisJim DimitrisJim moved this from Todo to Done in ibc-go Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
03-connection e2e
Projects
ibc-go
Archived in project
Milestone
v8.0.0
Development

No branches or pull requests
2 participants
@crodriguezvega @DimitrisJim