feat(connection): migrate connection params #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
leaving this as a draft until #3640 is merged. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3650 +/- ##
==========================================
- Coverage 78.80% 78.74% -0.06%
==========================================
Files 187 187
Lines 12846 12888 +42
==========================================
+ Hits 10123 10149 +26
- Misses 2292 2308 +16
Partials 431 431
|
DimitrisJim
force-pushed
the
jim/3501-migrate-03-connection-params-to-be-self-managed
branch
9 times, most recently
from
812e67f
to
b1c4e69
Compare
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan,
chatton and
srdtrk
as code owners
There was a problem hiding this comment.
I think looks good, @DimitrisJim! I just left a couple of comments.
DimitrisJim
force-pushed
the
jim/3501-migrate-03-connection-params-to-be-self-managed
branch
from
b1c4e69
to
1cb9375
Compare
DimitrisJim
commented
May 31, 2023
e2e/testsuite/grpc_query.go
Outdated
| @@ -73,6 +73,7 @@ func (s *E2ETestSuite) InitGRPCClients(chain *cosmos.CosmosChain) { | |||
|
|
|||
| s.grpcClients[chain.Config().ChainID] = GRPCClients{ | |||
| ClientQueryClient: clienttypes.NewQueryClient(grpcConn), | |||
| ConnectionQueryClient: connectiontypes.NewQueryClient(grpcConn), | |||
There was a problem hiding this comment.
the wonders of allowing default initialization.
There was a problem hiding this comment.
I just stumbled upon this error when running the v7.1 upgrade test. :)
There was a problem hiding this comment.
Multiple victims of this unforgiving language design
DimitrisJim
force-pushed
the
jim/3501-migrate-03-connection-params-to-be-self-managed
branch
from
0364f34
to
be0461b
Compare
1 task
damiannolan
reviewed
May 31, 2023
9 tasks
DimitrisJim
force-pushed
the
jim/3501-migrate-03-connection-params-to-be-self-managed
branch
3 times, most recently
from
acbc432
to
4ef0dc9
Compare
9 tasks
DimitrisJim
force-pushed
the
jim/3501-migrate-03-connection-params-to-be-self-managed
branch
from
4ef0dc9
to
adb29be
Compare
damiannolan
approved these changes
Jun 1, 2023
DimitrisJim
force-pushed
the
jim/3501-migrate-03-connection-params-to-be-self-managed
branch
from
b3e9af6
to
52e6730
Compare
crodriguezvega
approved these changes
Jun 2, 2023
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
DimitrisJim
force-pushed
the
jim/3501-migrate-03-connection-params-to-be-self-managed
branch
from
e1d60fe
to
1925102
Compare
DimitrisJim
deleted the
jim/3501-migrate-03-connection-params-to-be-self-managed
branch
colin-axner
reviewed
Jun 5, 2023
| if _, err := sdk.AccAddressFromBech32(msg.Authority); err != nil { | ||
| return errorsmod.Wrapf(ibcerrors.ErrInvalidAddress, "string could not be parsed as address: %v", err) | ||
| } | ||
| return msg.Params.Validate() |
There was a problem hiding this comment.
Params.Validate() returns a fmt.Errorf error, this will result in the default SDK internal error code of 1 since no registered error is returned. Previously this validation was only called in InitGenesis where you don't need to return sdk registered errors, we may want to update this now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3501
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.