Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate import statements by type #382

Closed
3 tasks
seantking opened this issue Sep 7, 2021 · 2 comments · Fixed by #702
Closed
3 tasks

Separate import statements by type #382

seantking opened this issue Sep 7, 2021 · 2 comments · Fixed by #702
Assignees
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@seantking
Copy link
Contributor

seantking commented Sep 7, 2021

Summary

Following on from the comment suggesting to update import statements.

For example, the imports here should be refactored to look like:

import (
        // standard library imports
	"fmt"
	"testing"
        
        // external library imports
	"github.com/stretchr/testify/require"
	abci "github.com/tendermint/tendermint/abci/types"
        
         // ibc-go library imports
	"github.com/cosmos/ibc-go/modules/core/23-commitment/types"
)

This needs to be done throughout most of the repo.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking added good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces labels Sep 7, 2021
@nickmancari
Copy link

I can do this, I'd love to help out.

@crodriguezvega crodriguezvega added this to the v2.0.2 milestone Nov 23, 2021
@crodriguezvega
Copy link
Contributor

Hi @nickmancari. Are you still willing to work on this? No problem if you can't!

@crodriguezvega crodriguezvega self-assigned this Jan 9, 2022
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants