-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GetHeight from ClientMessage interface #594
Labels
02-client
core
needs discussion
Issues that need discussion before they can be worked on
type: refactor
Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Comments
colin-axner
changed the title
Remove GetLatestHeight from client state interface
Remove GetHeight from header interface
Dec 7, 2021
crodriguezvega
added
the
type: refactor
Architecture, code or CI improvements that may or may not tackle technical debt.
label
Jan 3, 2022
faddat
pushed a commit
to notional-labs/ibc-go
that referenced
this issue
Feb 23, 2022
Update changelog
9 tasks
crodriguezvega
added
the
needs discussion
Issues that need discussion before they can be worked on
label
Apr 4, 2022
Relayer operators might need |
damiannolan
changed the title
Remove GetHeight from header interface
Remove GetHeight from ClientMessage interface
Apr 20, 2022
Updated issue to reflect new interface naming 👍 |
After the discussion in #1208 linked above, the proposed solution moving forward is as follows:
|
This was referenced Apr 21, 2022
closed! Great work @damiannolan |
Repository owner
moved this from In review
to Done
in ibc-go
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
02-client
core
needs discussion
Issues that need discussion before they can be worked on
type: refactor
Architecture, code or CI improvements that may or may not tackle technical debt.
Summary
Following implementation of #284, #285, and #286, GetHeight will no longer be necessary. This removal is necessary for the Wasm Light Client
Remove
GetHeight
from theHeaderClientMessage
interface. Usage in 07-tendermint can use the casted header function (cast to 07-tendermint type and use the concrete function)Should be done after no longer setting the consensus state in updates in 02-client
For Admin Use
The text was updated successfully, but these errors were encountered: