Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent terminology for coin/token in transfer. #6379

Closed
2 of 3 tasks
DimitrisJim opened this issue May 24, 2024 · 4 comments · Fixed by #6446
Closed
2 of 3 tasks

Consistent terminology for coin/token in transfer. #6379

DimitrisJim opened this issue May 24, 2024 · 4 comments · Fixed by #6446
Assignees
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

Opening this after #6364 and #6352 (comment)

Would be nice to use consistent terminology for coins and the newly added Token type so as to not cause confusion when reviewing/changing things. There should be some places where these are used interchangeably (as the review comment pointed out). Some internal private functions could also be renamed to better align with these types.

Can probably be left for until v2 of ics20 is merged.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added the type: code hygiene Clean up code but without changing functionality or interfaces label May 24, 2024
@DimitrisJim DimitrisJim mentioned this issue May 24, 2024
10 tasks
@colin-axner colin-axner self-assigned this May 27, 2024
@crodriguezvega
Copy link
Contributor

Can we already consider this done?

@DimitrisJim
Copy link
Contributor Author

I can look through codebase and close if needed (unless you've done so!)

@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Jun 3, 2024

escrowToken -> escrowCoin, unescrowToken -> unescrowCoin seem to be the only relevant ones. I recall seeing them in a PR, though but maybe the one that was closed, will fix up real quick.

@colin-axner
Copy link
Contributor

thanks, was gonna get to this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Archived in project
3 participants