You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would be nice to use consistent terminology for coins and the newly added Token type so as to not cause confusion when reviewing/changing things. There should be some places where these are used interchangeably (as the review comment pointed out). Some internal private functions could also be renamed to better align with these types.
Can probably be left for until v2 of ics20 is merged.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
escrowToken -> escrowCoin, unescrowToken -> unescrowCoin seem to be the only relevant ones. I recall seeing them in a PR, though but maybe the one that was closed, will fix up real quick.
Opening this after #6364 and #6352 (comment)
Would be nice to use consistent terminology for coins and the newly added
Token
type so as to not cause confusion when reviewing/changing things. There should be some places where these are used interchangeably (as the review comment pointed out). Some internal private functions could also be renamed to better align with these types.Can probably be left for until v2 of ics20 is merged.
For Admin Use
The text was updated successfully, but these errors were encountered: