Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe found a query bug in interchain-accounts #665

Closed
3 tasks
okwme opened this issue Dec 22, 2021 · 2 comments · Fixed by #666
Closed
3 tasks

Maybe found a query bug in interchain-accounts #665

okwme opened this issue Dec 22, 2021 · 2 comments · Fixed by #666
Labels
27-interchain-accounts type: bug Something isn't working as expected

Comments

@okwme
Copy link

okwme commented Dec 22, 2021

Summary of Bug

When running a CLI query on the interchain-accounts module (host and controller subcommand) I see an error.

Version

https://github.com/cosmos/gaia/tree/ica-acct-auth

Steps to Reproduce

> gaiad q interchain-accounts controller params --home ~/.gaiad2
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x51de662]

goroutine 1 [running]:
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/client/cli.GetCmdParams.func1(0xc001135b80, {0xc001126ee0, 0x0, 0x2})
	github.com/cosmos/ibc-go/v3@v3.0.0-20211220113545-e3036e36200c/modules/apps/27-interchain-accounts/controller/client/cli/query.go:30 +0x182
github.com/spf13/cobra.(*Command).execute(0xc001135b80, {0xc001126ec0, 0x2, 0x2})
	github.com/spf13/cobra@v1.3.0/command.go:856 +0x60e
github.com/spf13/cobra.(*Command).ExecuteC(0xc001048c80)
	github.com/spf13/cobra@v1.3.0/command.go:974 +0x3bc
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.3.0/command.go:902
github.com/spf13/cobra.(*Command).ExecuteContext(...)
	github.com/spf13/cobra@v1.3.0/command.go:895
github.com/cosmos/cosmos-sdk/server/cmd.Execute(0x0, {0xc000e752f0, 0x12})
	github.com/cosmos/cosmos-sdk@v0.44.5/server/cmd/execute.go:36 +0x1eb
main.main()
	github.com/cosmos/gaia/v6/cmd/gaiad/main.go:16 +0x2c

I maybe also jsut mis-configured the


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@okwme
Copy link
Author

okwme commented Dec 22, 2021

I found this bug while trying to see if I could see he status of a transaction that was submitted to the host chain from the controller chain. Would love to get something like a TX hash that I can use to see if my TX failed on the host chain. Or query the host chain with my account to see a list of transactions?

@colin-axner colin-axner added the type: bug Something isn't working as expected label Dec 23, 2021
@colin-axner
Copy link
Contributor

thanks @okwme! I opened #666 which fixes the issue (but you'll need to restart your chain with the updated binary)

As far as seeing the status of a tx. The ICA auth module will receive the acknowledgement result in OnAcknowledgement, it could log the result there or we can ensure the packet sequence used to send the transaction is returned to the user. Then you could query for the acknowledgement on the host chain. We could add a command to ica which parses the acknowledgement result

faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
)

* fixing merge conflicts

* fix breaking changes related to substore, prefixing, and keys

* fix all the failing tests

* test that is no longer needed

* fix missing merge conflict

* fixing golangci-lint errors

* more lint errors

* goimports fixes

* fixing golangci-lint failures

* changing from DataStore to TxnDatasource, cutting some LOC, prefix entires as iterator, etc

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-interchain-accounts type: bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants