Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize middleware stacks #773

Closed
6 tasks
seantking opened this issue Jan 19, 2022 · 0 comments · Fixed by #1248
Closed
6 tasks

Organize middleware stacks #773

seantking opened this issue Jan 19, 2022 · 0 comments · Fixed by #1248
Assignees
@seantking
Labels
29-fee
Milestone
Fee middleware RC

Comments

@seantking
Copy link
Contributor

Summary

At present, the current initialization of the middleware stacks is difficult to parse. Some refactoring here might make it easier for newcomers.

Cleanup app.go by organizing the creation of middleware stacks/routing so it is easy to follow:

  • group keeper creation
  • group app module creation
  • make a middleware stack/route at the same time

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking added this to the Fee Middleware milestone Jan 19, 2022
@seantking seantking self-assigned this Apr 11, 2022
@seantking seantking mentioned this issue Apr 14, 2022
Merged
9 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@nashqueue
Refactor: Header -> Signed Header (cosmos#771)
4039cbe 
Fixes: cosmos#773

---------

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seantking seantking

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware RC
Development

Successfully merging a pull request may close this issue.

refactor: cleanup middleware stacks cosmos/ibc-go
2 participants
@crodriguezvega @seantking