Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe deletion during iteration of ics29 channels in DisableAllChannels #780

Closed
3 tasks
colin-axner opened this issue Jan 21, 2022 · 2 comments · Fixed by #1244
Closed
3 tasks

Unsafe deletion during iteration of ics29 channels in DisableAllChannels #780

colin-axner opened this issue Jan 21, 2022 · 2 comments · Fixed by #1244
Assignees
@colin-axner
Labels
29-fee type: bug Something isn't working as expected
Milestone
Fee middleware beta

Comments

@colin-axner
Copy link
Contributor

Summary

see comment.

Fix:
First iterate over all channels collecting a slice of keys. Then iterate over the slice of keys and delete all the mappings

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Jan 21, 2022
Merged
9 tasks
@colin-axner colin-axner added 29-fee type: bug Something isn't working as expected labels Jan 21, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Feb 7, 2022
@crodriguezvega crodriguezvega moved this from Todo to Backlog in ibc-go Feb 7, 2022
@colin-axner colin-axner self-assigned this Feb 28, 2022
@colin-axner colin-axner mentioned this issue Feb 28, 2022
Closed
9 tasks
@crodriguezvega crodriguezvega added this to the Fee middleware beta milestone Mar 29, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Apr 4, 2022
@crodriguezvega
Copy link
Contributor

I think this can be closed because it's superseded by #821.

@colin-axner
Copy link
Contributor Author

We should close it when the code gets deleted. #821 indirectly fixes this issue, although it is possible to close #821 without removing this code

@colin-axner colin-axner mentioned this issue Apr 11, 2022
Merged
9 tasks
@mergify mergify bot closed this as completed in #1244 Apr 13, 2022
mergify bot pushed a commit that referenced this issue Apr 13, 2022
@colin-axner
refactor: Fix RefundFeesOnChannel (#1244)
e59a6d2 
## Description

read #1060 

closes: #860
closes: #780 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [x] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [x] Review `Codecov Report` in the comment section below once CI passes
Repository owner moved this from Todo to Done in ibc-go Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
29-fee type: bug Something isn't working as expected
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
Development

Successfully merging a pull request may close this issue.

refactor: Fix RefundFeesOnChannel cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner