Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC for Relayers to query which channels are incentivized #857

Closed
AdityaSripal opened this issue Feb 7, 2022 · 1 comment · Fixed by #1225
Closed

gRPC for Relayers to query which channels are incentivized #857

AdityaSripal opened this issue Feb 7, 2022 · 1 comment · Fixed by #1225
Assignees
@damiannolan
Labels
29-fee
Milestone
Fee middleware beta

Comments

@AdityaSripal
Copy link
Member

Since channelID/portID does not include fee information, we need a rpc that tells relayers whether or not a given channel is incentivized
@crodriguezvega crodriguezvega added this to the Fee middleware beta milestone Mar 29, 2022
@crodriguezvega crodriguezvega mentioned this issue Apr 4, 2022
Closed
6 tasks
@damiannolan damiannolan self-assigned this Apr 5, 2022
@damiannolan
Copy link
Member

I think we should possibly include two queries here. One to return all fee enabled channels and one to return whether or not a channel is fee enabled given its channel/port ID.

This was referenced Apr 6, 2022
Closed
Merged
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@dependabot
build(deps): bump github.com/celestiaorg/go-header from 0.2.3 to 0.2.4 (
acf202b 
cosmos#857)

Bumps
[github.com/celestiaorg/go-header](https://github.com/celestiaorg/go-header)
from 0.2.3 to 0.2.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/celestiaorg/go-header/releases">github.com/celestiaorg/go-header's
releases</a>.</em></p>
<blockquote>
<h2>v0.2.4</h2>
<h2>What's Changed</h2>
<ul>
<li>refactor: reduce empty response to DEBUG log by <a
href="https://github.com/distractedm1nd"><code>@​distractedm1nd</code></a>
in <a
href="https://redirect.github.com/celestiaorg/go-header/pull/23">celestiaorg/go-header#23</a></li>
<li>feat: add README.md + Makefile + lint, test and generate coverage by
<a href="https://github.com/derrandz"><code>@​derrandz</code></a> in <a
href="https://redirect.github.com/celestiaorg/go-header/pull/18">celestiaorg/go-header#18</a></li>
<li>refactor(headertest)!: unify, prettify and generify testing
utilities by <a
href="https://github.com/Wondertan"><code>@​Wondertan</code></a> in <a
href="https://redirect.github.com/celestiaorg/go-header/pull/24">celestiaorg/go-header#24</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/distractedm1nd"><code>@​distractedm1nd</code></a>
made their first contribution in <a
href="https://redirect.github.com/celestiaorg/go-header/pull/23">celestiaorg/go-header#23</a></li>
<li><a href="https://github.com/derrandz"><code>@​derrandz</code></a>
made their first contribution in <a
href="https://redirect.github.com/celestiaorg/go-header/pull/18">celestiaorg/go-header#18</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/celestiaorg/go-header/compare/v0.2.3...v0.2.4">https://github.com/celestiaorg/go-header/compare/v0.2.3...v0.2.4</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/celestiaorg/go-header/commit/f991fba218f291ee2e6c8320e47a18f3b5903dc4"><code>f991fba</code></a>
remove import alias</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/f8168e7256390487fca725d97b9e43db2e16da85"><code>f8168e7</code></a>
lint</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/54b93923955d2309ac7f3f74b3e86751ded50edb"><code>54b9392</code></a>
refactor(headertest): unify, prettify and generify testing
utilities</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/598c99daba9129a9d10ac1fe06b8b163c7167347"><code>598c99d</code></a>
Merge pull request <a
href="https://redirect.github.com/celestiaorg/go-header/issues/18">#18</a>
from derrandz/misc/readme+makefile</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/62698737171119ef867bf9622833d146ad2eda1c"><code>6269873</code></a>
Merge branch 'main' into misc/readme+makefile</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/9b1bd206eb7a72bb9be53bdd9b5a31d858c715e5"><code>9b1bd20</code></a>
Merge pull request <a
href="https://redirect.github.com/celestiaorg/go-header/issues/23">#23</a>
from celestiaorg/debug-log</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/c59a3e5d04dfdba0164192767a5854e0130c5ad1"><code>c59a3e5</code></a>
refactor: simplify switch</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/0ffca2806cf867dbdf7c66bfb3beef033bf8b431"><code>0ffca28</code></a>
refactor: reduce empty response to DEBUG log</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/7eb8712f8ba843aa9b8e320e6c5e3fb4828ecea0"><code>7eb8712</code></a>
pr: address comments</li>
<li><a
href="https://github.com/celestiaorg/go-header/commit/cd2cb9e2b6fbec49d805ffce2665227367dca6a4"><code>cd2cb9e</code></a>
feat: add README.md + Makefile + lint, test and generate coverage</li>
<li>See full diff in <a
href="https://github.com/celestiaorg/go-header/compare/v0.2.3...v0.2.4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/celestiaorg/go-header&package-manager=go_modules&previous-version=0.2.3&new-version=0.2.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
Development

Successfully merging a pull request may close this issue.

feat: ics29 fee enabled channel queries cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @AdityaSripal