Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sender to fungible_token_packet events #996

Closed
3 tasks
minxylynx opened this issue Feb 24, 2022 · 2 comments · Fixed by #1414
Closed
3 tasks

Add Sender to fungible_token_packet events #996

minxylynx opened this issue Feb 24, 2022 · 2 comments · Fixed by #1414
Assignees
@chatton
Labels
20-transfer type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Q2-2022-backlog

Comments

@minxylynx
Copy link

Summary

When creating the fungible_token_packet events, we have access to the sender information. It would be a small win to add the sender field so those events can be tracked accurately.

Problem Definition

When a packet is received, or acknowledged, the data object contains the sender value, but is not included in the fungible_token_packet event emission. When Smart Contracts are used to perform IBC actions, clients (ie, explorers) would use the events emitted to track IBC movement. Without the sender field, its impossible to match a transfer to acknowledgement, or recvPacket to acknowledgement.

Proposal

Update usages of https://github.com/cosmos/ibc-go/blob/v2.0.3/modules/apps/transfer/types/events.go#L6 to include sender as an event attribute.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 20-transfer labels Feb 24, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Feb 24, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Mar 7, 2022
@crodriguezvega crodriguezvega moved this from Todo to Backlog in ibc-go Mar 21, 2022
@crodriguezvega crodriguezvega added this to the Q2-2022-backlog milestone Mar 31, 2022
@crodriguezvega
Copy link
Contributor

  • Add sdk.AttributeKeySender to events here and here with data.Sender.

@chatton chatton mentioned this issue May 23, 2022
Merged
9 tasks
Repository owner moved this from Backlog to Done in ibc-go May 23, 2022
@crodriguezvega
Copy link
Contributor

This is now available in v3.1.0, v3.0.1, v2.3.0, v2.2.1, v2.1.1, v1.5.0, v1.4.1 and v1.3.1.

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@MSevey
extend dataRequestErrorToStatus testing (cosmos#996)
4674e78 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Extend the unit testing to cover more test cases and turn into a table
test as an example for future unit testing.

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
20-transfer type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
Q2-2022-backlog
Development

Successfully merging a pull request may close this issue.

feat: Add sender to fungible_token_packet events
3 participants
@crodriguezvega @chatton @minxylynx