Modify all message constructors to take in a string for address #108
Conversation
All NewMsg() functions take in the signer as a string. This prevents bugs from happening at the level of the caller since String relies on external context
| ) | ||
|
|
||
| var ( | ||
| signer = "cosmos1ckgw5d7jfj7wwxjzs9fdrdev9vc8dzcw3n2lht" |
There was a problem hiding this comment.
Is there a way to test in the testing package that this new feature will help with switching out bech32 prefixes?
There was a problem hiding this comment.
Yes and no. We could switch out the configs bech32 prefix like how the relayer does, but this would just be testing .String() function.
.String() relies on the bech32 prefix set in the config. It is up to the caller of .String() to ensure the config has the set the correct bech32 prefix. This pr just removes ibc-go from calling .String() and enforces the caller to have control over when .String() is called, which will hopefully lead the caller to avoid bugs and/or debug the issue easier
We cannot prevent the caller from setting the config incorrectly and passing in the wrong string
Bumps [github.com/ipfs/go-log](https://github.com/ipfs/go-log) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/ipfs/go-log/releases) - [Commits](ipfs/go-log@v1.0.4...v1.0.5) --- updated-dependencies: - dependency-name: github.com/ipfs/go-log dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description
closes: #73
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes