Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: improve Logger performance #1160

Merged
merged 8 commits into from
Apr 5, 2022
Merged

imp: improve Logger performance #1160

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4035ee9
fix: Logger marshal errors
fedekunze Mar 22, 2022
20e34d0
Merge branch 'main' of github.com:cosmos/ibc-go into fedekunze/fix-logs
fedekunze Mar 22, 2022
4c9954f
changelog
fedekunze Mar 22, 2022
a220efd
Merge branch 'main' into fedekunze/fix-logs
fedekunze Mar 26, 2022
6090150
Merge branch 'main' of github.com:cosmos/ibc-go into fedekunze/fix-logs
fedekunze Apr 5, 2022
964adfd
update
fedekunze Apr 5, 2022
392493f
Merge branch 'main' into fedekunze/fix-logs
fedekunze Apr 5, 2022
c5bfede
Merge branch 'fedekunze/fix-logs' of github.com:cosmos/ibc-go into fe…
fedekunze Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

* (modules/core/04-channel) [\#1160](https://github.com/cosmos/ibc-go/pull/1160) Fix marshal errors on logger.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry needs to be changed to be performance improvement

* (modules/core/04-channel) [\#1130](https://github.com/cosmos/ibc-go/pull/1130) Call `packet.GetSequence()` rather than passing func in `WriteAcknowledgement` log output

## [v3.0.0](https://github.com/cosmos/ibc-go/releases/tag/v3.0.0) - 2022-03-15
Expand Down
7 changes: 4 additions & 3 deletions modules/core/04-channel/keeper/packet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package keeper

import (
"bytes"
"strconv"
"time"

sdk "github.com/cosmos/cosmos-sdk/types"
Expand Down Expand Up @@ -129,7 +130,7 @@ func (k Keeper) SendPacket(

k.Logger(ctx).Info(
"packet sent",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down Expand Up @@ -284,7 +285,7 @@ func (k Keeper) RecvPacket(
// log that a packet has been received & executed
k.Logger(ctx).Info(
"packet received",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down Expand Up @@ -494,7 +495,7 @@ func (k Keeper) AcknowledgePacket(
// log that a packet has been acknowledged
k.Logger(ctx).Info(
"packet acknowledged",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down
3 changes: 2 additions & 1 deletion modules/core/04-channel/keeper/timeout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package keeper

import (
"bytes"
"strconv"

sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
Expand Down Expand Up @@ -159,7 +160,7 @@ func (k Keeper) TimeoutExecuted(

k.Logger(ctx).Info(
"packet timed-out",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down