Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding CheckForMisbehaviour to ClientState interface #1197

Merged

Conversation

seantking
Copy link
Contributor

Description

closes: #1192


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for removing TODOs in tests with casting.

https://github.com/cosmos/ibc-go/blob/02-client-refactor/modules/light-clients/07-tendermint/types/update_test.go#L745

I think that's the only one for this! :)

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending changelog and removing of TODOs @damiannolan linked

@seantking seantking enabled auto-merge (squash) March 31, 2022 12:08
@seantking seantking merged commit d2be6d5 into 02-client-refactor Mar 31, 2022
@seantking seantking deleted the sean/issue#1192-add-check-for-misb-to-interface branch March 31, 2022 14:31
seunlanlege pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
* feat: adding CheckForMisbehaviour to ClientState interface

* fix: comment

* nit: fix todo

* chore: changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants