Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make URI path for getting all incentivized packets for channel consistent #1278

Merged
merged 5 commits into from
Apr 21, 2022
Merged

make URI path for getting all incentivized packets for channel consistent #1278

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33ae2a8
make URI path for getting all incentivized packets for a specific cha…
crodriguezvega Apr 20, 2022
3407c3a
regenerate proto files and add changelog entry
Apr 20, 2022
8bd7b98
something going with go.mod file...
Apr 20, 2022
01d0db0
Merge branch 'main' into carlos/uri-path-get-incentivized-packets-for…
crodriguezvega Apr 20, 2022
1c1e93f
update changelog entry
crodriguezvega Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proto/ibc/applications/fee/v1/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ service Query {
// Gets all incentivized packets for a specific channel
rpc IncentivizedPacketsForChannel(QueryIncentivizedPacketsForChannelRequest)
returns (QueryIncentivizedPacketsForChannelResponse) {
option (google.api.http).get = "/ibc/apps/fee/v1/incentivized_packets/{port_id}/{channel_id}";
option (google.api.http).get = "/ibc/apps/fee/v1/incentivized_packets/port/{port_id}/channel/{channel_id}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

}

// TotalRecvFees returns the total receive fees for a packet given its identifier
Expand Down