Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration docs for 02-client refactor #1287

Merged
merged 25 commits into from
May 10, 2022
Merged

Add migration docs for 02-client refactor #1287

merged 25 commits into from
May 10, 2022

Conversation

catShaark
Copy link
Contributor

…ht client impl to migration doc

Description

I add migration docs for 02-client refactor, this should clearly explain how to go from the old 02-client API to the new API

closes: #1202

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@catShaark catShaark force-pushed the add-migration-docs-for-client-refactor branch from 13dad85 to 1fc561e Compare April 25, 2022 03:19
colin-axner
colin-axner reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
catShaark and others added 5 commits April 25, 2022 18:54
@catShaark @colin-axner
Update docs/migrations/v3-to-v4.md
0e7bd3a 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@catShaark @colin-axner
Update docs/migrations/v3-to-v4.md
7db7f72 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@catShaark @colin-axner
Update docs/migrations/v3-to-v4.md
250353d 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@catShaark @colin-axner
Update docs/migrations/v3-to-v4.md
4699eb2 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@catShaark @colin-axner
Update docs/migrations/v3-to-v4.md
5b7f447 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@catShaark
Copy link
Contributor Author

catShaark commented Apr 25, 2022 •
edited
Loading

Thank you so much for reviewing this. @colin-axner. I'll apply the changes needed

catShaark and others added 2 commits April 25, 2022 19:02
@catShaark @colin-axner
Update docs/migrations/v3-to-v4.md
4de0e29 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@catShaark
add more entries and more description
6c9551f
@catShaark catShaark force-pushed the add-migration-docs-for-client-refactor branch from fad2d0f to 6c9551f Compare April 26, 2022 02:48
crodriguezvega
crodriguezvega reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this. I just left some nits. :)

docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Show resolved Hide resolved
docs/migrations/v3-to-v4.md Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
catShaark and others added 7 commits April 26, 2022 13:26
@catShaark
Update docs/migrations/v3-to-v4.md
8c77483 
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@catShaark
Update docs/migrations/v3-to-v4.md
060988a 
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@catShaark
Update docs/migrations/v3-to-v4.md
1c546b9 
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@catShaark
Update docs/migrations/v3-to-v4.md
2f890d2 
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@catShaark
Update docs/migrations/v3-to-v4.md
fefb363 
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@catShaark
Update docs/migrations/v3-to-v4.md
1a27799 
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@catShaark
Update docs/migrations/v3-to-v4.md
318a2d5 
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@catShaark
Copy link
Contributor Author

Thanks for reviewing this, @crodriguezvega

@catShaark catShaark changed the title add changes on : ClientState, Header, Misbehaviour, ConsensState, lig… Add migration docs for 02-client refactor Apr 26, 2022
@catShaark
Update docs/migrations/v3-to-v4.md
5886fed 
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@catShaark @seantking
Update docs/migrations/v3-to-v4.md
ee9eb5f 
Co-authored-by: Sean King <seantking@users.noreply.github.com>
seantking
seantking approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@seantking seantking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work :-)

catShaark and others added 2 commits April 29, 2022 10:24
colin-axner
colin-axner approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Show resolved Hide resolved
@crodriguezvega crodriguezvega merged commit e1f2103 into cosmos:02-client-refactor May 10, 2022
@colin-axner colin-axner mentioned this pull request May 10, 2022
Closed
3 tasks
@crodriguezvega crodriguezvega mentioned this pull request May 30, 2022
Merged
9 tasks
oshorefueled pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
@catShaark @colin-axner
@seantking @oshorefueled
Add migration docs for 02-client refactor (cosmos#1287)
2a6aa3a 
* add changes on : ClientState, Header, Misbehaviour, ConsensState, light client impl  to migration doc

* Update docs/migrations/v3-to-v4.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* add more entries and more description

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Sean King <seantking@users.noreply.github.com>

* Update docs/migrations/v3-to-v4.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* update migration doc

* update migration doc

* update migration doc

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Sean King <seantking@users.noreply.github.com>
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
@gupadhyaya
loop through all txs before returning (cosmos#1287)
ff4b754 
Fixes cosmos#1283 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

Refactor:
- Improvement: Enhanced the transaction handling process in the
`TxMempool` module. Transactions are now more accurately filtered based
on their gas and data size limits, ensuring that only valid transactions
are processed. This update improves the overall efficiency and
reliability of transaction processing.

Tests:
- Test: Added a new test, `TestTxMempoolTxLargerThanMaxBytes`, to verify
the correct handling of large transactions. This ensures the robustness
of the system when dealing with transactions of varying sizes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@seantking seantking seantking approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@charleenfei charleenfei Awaiting requested review from charleenfei

@damiannolan damiannolan Awaiting requested review from damiannolan

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catShaark @crodriguezvega @seantking @colin-axner