-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding fee middleware support to ics27 interchain accounts #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport fee middleware functionality
damiannolan
requested review from
seantking,
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
May 25, 2022 10:28
9 tasks
crodriguezvega
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, @damiannolan!
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Codecov Report
@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
+ Coverage 80.34% 80.36% +0.01%
==========================================
Files 166 166
Lines 12081 12088 +7
==========================================
+ Hits 9707 9715 +8
Misses 1918 1918
+ Partials 456 455 -1
|
AdityaSripal
approved these changes
Jun 1, 2022
|
||
The `WriteAcknowledgement` API now takes the `exported.Acknowledgement` type instead of passing in the acknowledgement byte array directly. | ||
This is an API breaking change and as such IBC application developers will have to update any calls to `WriteAcknowledgement`. | ||
|
||
The `OnChanOpenInit` application callback has been modified. | ||
The return signature now includes the application version as detailed in the latest IBC [spec changes](https://github.com/cosmos/ibc/pull/629). | ||
|
||
### ICS27 - Interchain Accounts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice docs!
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR adds support to
apps/27-interchain-accounts
to work in an application stack composed withapps/29-fee
.version
arg toRegisterInterchainAccount
and updating godocs.RegisterInterchainAccount
and passing through the newversion
arg toMsgChannelOpenInit
directly - this supports both fee-disabled and fee-enabled channels in an application stack composed with ics29 middleware.simapp
to include29-fee
in interchain accounts controller and host app stacks.closes: #1356
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes