Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed gRPC web route to consensus_states/{client_id}/heights #1517

Merged

Conversation

crodriguezvega
Copy link
Contributor

Description

While I was backporting #1336 I realized that the gRPC web route for consensus_state/heights/{client_id} was not aligning with the URL format that we want to have, so I am changing it to consensus_state/{client_id}/heights. I have already made the same change in the branches to backport the PR that are currently open: #1505 #1506 #1507

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crodriguezvega crodriguezvega changed the title refactor: changed gRPC web route to consensus_state/{client_id}/heights refactor: changed gRPC web route to consensus_state/{client_id}/heights Jun 9, 2022
@crodriguezvega crodriguezvega changed the title refactor: changed gRPC web route to consensus_state/{client_id}/heights refactor: changed gRPC web route to consensus_states/{client_id}/heights Jun 9, 2022
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

proto/ibc/core/client/v1/query.proto Show resolved Hide resolved
@crodriguezvega crodriguezvega merged commit da232b8 into main Jun 11, 2022
@crodriguezvega crodriguezvega deleted the carlos/refactor-consensusstates-heights-get-route branch June 11, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants