Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cmd: query ibc-transfer escrow-address #198

Merged
merged 7 commits into from
May 27, 2021

Conversation

ebuchman
Copy link
Member

@ebuchman ebuchman commented May 26, 2021

Description

New command to get the escrow address for a channel.

Already merged into the cosmos-sdk release/v0.42.x branch: cosmos/cosmos-sdk#9383

closes: #189


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

}
port := args[0]
channel := args[1]
addr := GetEscrowAddress(port, channel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this building? Shouldn't it be types.GetEscrowAddress?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh it isn't building

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my goodness I'm sorry about that, thanks for covering!

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK, thanks!

simd q ibc-transfer escrow-address transfer channel-0
cosmos1a53udazy8ayufvy0s434pfwjcedzqv34kvz9tw

@colin-axner colin-axner enabled auto-merge (squash) May 27, 2021 10:28
@colin-axner colin-axner merged commit 79659be into main May 27, 2021
@colin-axner colin-axner deleted the bucky/query-escrow-address branch May 27, 2021 11:43
faddat referenced this pull request in notional-labs/ibc-go Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query ibc-transfer escrow-address
3 participants