-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updating v3->v4 migration docs with fee middleware #2127
Merged
damiannolan
merged 5 commits into
main
from
sean/issue#2089-fee-middleware-migration-docs
Sep 26, 2022
Merged
docs: updating v3->v4 migration docs with fee middleware #2127
damiannolan
merged 5 commits into
main
from
sean/issue#2089-fee-middleware-migration-docs
Sep 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantking
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
August 25, 2022 12:37
colin-axner
reviewed
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we are still missing a bit of information on integrating ics29. If a chain goes from v3, we should be linking enough information to upgrade without looking at our code. Maybe we should do this in a followup pr?
colin-axner
approved these changes
Sep 21, 2022
opened #2354 |
damiannolan
approved these changes
Sep 26, 2022
damiannolan
deleted the
sean/issue#2089-fee-middleware-migration-docs
branch
September 26, 2022 14:25
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be)
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be)
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be)
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be)
damiannolan
pushed a commit
that referenced
this pull request
Sep 26, 2022
* updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be) Co-authored-by: Sean King <seantking@users.noreply.github.com>
damiannolan
pushed a commit
that referenced
this pull request
Sep 26, 2022
* updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be) Co-authored-by: Sean King <seantking@users.noreply.github.com>
damiannolan
pushed a commit
that referenced
this pull request
Sep 26, 2022
* updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be) Co-authored-by: Sean King <seantking@users.noreply.github.com>
damiannolan
added a commit
that referenced
this pull request
Sep 26, 2022
* updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be) Co-authored-by: Sean King <seantking@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
9 tasks
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 27, 2023
cosmos#2389) * updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be) Co-authored-by: Sean King <seantking@users.noreply.github.com>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
cosmos#2389) * updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be) Co-authored-by: Sean King <seantking@users.noreply.github.com>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
cosmos#2389) * updating v3->v4 migration docs with fee middleware * fix: docs * self requests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 77c10be) Co-authored-by: Sean King <seantking@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2089
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes