Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating v3->v4 migration docs with fee middleware #2127

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

seantking
Copy link
Contributor

@seantking seantking commented Aug 25, 2022

Description

closes: #2089


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we are still missing a bit of information on integrating ics29. If a chain goes from v3, we should be linking enough information to upgrade without looking at our code. Maybe we should do this in a followup pr?

docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Show resolved Hide resolved
@seantking seantking marked this pull request as draft August 29, 2022 22:09
@colin-axner colin-axner marked this pull request as ready for review September 21, 2022 09:54
@colin-axner
Copy link
Contributor

opened #2354

@damiannolan damiannolan enabled auto-merge (squash) September 26, 2022 14:21
@damiannolan damiannolan merged commit 77c10be into main Sep 26, 2022
@damiannolan damiannolan deleted the sean/issue#2089-fee-middleware-migration-docs branch September 26, 2022 14:25
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)
damiannolan pushed a commit that referenced this pull request Sep 26, 2022
* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)

Co-authored-by: Sean King <seantking@users.noreply.github.com>
damiannolan pushed a commit that referenced this pull request Sep 26, 2022
* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)

Co-authored-by: Sean King <seantking@users.noreply.github.com>
damiannolan pushed a commit that referenced this pull request Sep 26, 2022
* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)

Co-authored-by: Sean King <seantking@users.noreply.github.com>
damiannolan added a commit that referenced this pull request Sep 26, 2022
* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)

Co-authored-by: Sean King <seantking@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 27, 2023
cosmos#2389)

* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)

Co-authored-by: Sean King <seantking@users.noreply.github.com>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
cosmos#2389)

* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)

Co-authored-by: Sean King <seantking@users.noreply.github.com>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
cosmos#2389)

* updating v3->v4 migration docs with fee middleware

* fix: docs

* self requests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit 77c10be)

Co-authored-by: Sean King <seantking@users.noreply.github.com>
@ulbqb ulbqb mentioned this pull request Jul 31, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3 to v4 migration docs doesn't include integration of fee middleware
3 participants