e2e: add client recovery proposal test #2130
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| package e2e | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "strings" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/strangelove-ventures/ibctest/ibc" | ||
| "github.com/strangelove-ventures/ibctest/test" | ||
| "github.com/stretchr/testify/suite" | ||
|
|
||
| "github.com/cosmos/ibc-go/e2e/testsuite" | ||
| "github.com/cosmos/ibc-go/e2e/testvalues" | ||
| clienttypes "github.com/cosmos/ibc-go/v5/modules/core/02-client/types" | ||
| ibcexported "github.com/cosmos/ibc-go/v5/modules/core/exported" | ||
| ibctesting "github.com/cosmos/ibc-go/v5/testing" | ||
| ) | ||
|
|
||
| func TestClientTestSuite(t *testing.T) { | ||
| suite.Run(t, new(ClientTestSuite)) | ||
| } | ||
|
|
||
| type ClientTestSuite struct { | ||
| testsuite.E2ETestSuite | ||
| } | ||
|
|
||
| // Status queries the current status of the client | ||
| func (s *ClientTestSuite) Status(ctx context.Context, chain ibc.Chain, clientID string) (string, error) { | ||
| queryClient := s.GetChainGRCPClients(chain).ClientQueryClient | ||
| res, err := queryClient.ClientStatus(ctx, &clienttypes.QueryClientStatusRequest{ | ||
| ClientId: clientID, | ||
| }) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| return res.Status, nil | ||
| } | ||
|
|
||
| func (s *ClientTestSuite) TestClientUpdateProposal_Succeeds() { | ||
| t := s.T() | ||
| ctx := context.TODO() | ||
|
|
||
| var ( | ||
| pathName string | ||
| relayer ibc.Relayer | ||
| subjectClientID string | ||
| substituteClientID string | ||
| badTrustingPeriod = time.Duration(time.Second) | ||
| ) | ||
|
|
||
| t.Run("create substitute client with correct trusting period", func(t *testing.T) { | ||
| relayer, _ = s.SetupChainsRelayerAndChannel(ctx) | ||
|
|
||
| // TODO: update when client identifier created is accessible | ||
| // currently assumes first client is 07-tendermint-0 | ||
| substituteClientID = clienttypes.FormatClientIdentifier(ibcexported.Tendermint, 0) | ||
|
|
||
| // TODO: replace with better handling of path names | ||
| pathName = fmt.Sprintf("%s-path-%d", s.T().Name(), 0) | ||
| pathName = strings.ReplaceAll(pathName, "/", "-") | ||
| }) | ||
|
|
||
| chainA, chainB := s.GetChains() | ||
| chainAWallet := s.CreateUserOnChainA(ctx, testvalues.StartingTokenAmount) | ||
|
|
||
| t.Run("create subject client with bad trusting period", func(t *testing.T) { | ||
| createClientOptions := ibc.CreateClientOptions{ | ||
| TrustingPeriod: badTrustingPeriod.String(), | ||
| } | ||
|
|
||
| s.SetupClients(ctx, relayer, createClientOptions) | ||
|
|
||
| // TODO: update when client identifier created is accessible | ||
| // currently assumes second client is 07-tendermint-1 | ||
| subjectClientID = clienttypes.FormatClientIdentifier(ibcexported.Tendermint, 1) | ||
| }) | ||
|
|
||
| time.Sleep(badTrustingPeriod) | ||
|
|
||
| t.Run("update substitute client", func(t *testing.T) { | ||
| s.UpdateClients(ctx, relayer, pathName) | ||
| }) | ||
|
|
||
| s.Require().NoError(test.WaitForBlocks(ctx, 1, chainA, chainB), "failed to wait for blocks") | ||
|
|
||
| t.Run("check status of each client", func(t *testing.T) { | ||
| t.Run("substitute should be active", func(t *testing.T) { | ||
| status, err := s.Status(ctx, chainA, substituteClientID) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(ibcexported.Active.String(), status) | ||
| }) | ||
|
|
||
| t.Run("subject should be expired", func(t *testing.T) { | ||
| status, err := s.Status(ctx, chainA, subjectClientID) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(ibcexported.Expired.String(), status) | ||
| }) | ||
| }) | ||
|
|
||
| t.Run("pass client update proposal", func(t *testing.T) { | ||
| proposal := clienttypes.NewClientUpdateProposal(ibctesting.Title, ibctesting.Description, subjectClientID, substituteClientID) | ||
| s.ExecuteGovProposal(ctx, chainA, chainAWallet, proposal) | ||
| }) | ||
|
|
||
| t.Run("check status of each client", func(t *testing.T) { | ||
| t.Run("substitute should be active", func(t *testing.T) { | ||
| status, err := s.Status(ctx, chainA, substituteClientID) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(ibcexported.Active.String(), status) | ||
| }) | ||
|
|
||
| t.Run("subject should be active", func(t *testing.T) { | ||
| status, err := s.Status(ctx, chainA, subjectClientID) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(ibcexported.Active.String(), status) | ||
| }) | ||
| }) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are a bit hacky, but I think it is better to just do this for now and figure out a better solution later. I think adding the endpoint type should solve the issue in both cases