chore: adding IsMiddlewareEnabled to ActiveChannel genesis type
#2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
damiannolan
requested review from
seantking,
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
colin-axner
approved these changes
Sep 7, 2022
| ConnectionId: keySplit[2], | ||
| PortId: keySplit[1], | ||
| ChannelId: string(iterator.Value()), | ||
| IsMiddlewareEnabled: k.IsMiddlewareEnabled(ctx, keySplit[1], string(iterator.Value())), |
There was a problem hiding this comment.
In the future, I think it'd probably be wise to set these key splits/iterator values to variables for readability purposes. I don't think it needs to change as this is a problem throughout our codebase (keysplit should probably be a parse func)
damiannolan
changed the title
IsMiddlewareEnabled to ActiveChannel genesis typeIsMiddlewareEnabled to ActiveChannel genesis type
Codecov Report
@@ Coverage Diff @@
## main #2177 +/- ##
=======================================
Coverage 79.48% 79.49%
=======================================
Files 173 173
Lines 12011 12015 +4
=======================================
+ Hits 9547 9551 +4
Misses 2042 2042
Partials 422 422
|
proto/ibc/applications/interchain_accounts/genesis/v1/genesis.proto
Outdated
Show resolved
Hide resolved
…proto Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
AdityaSripal
approved these changes
Sep 8, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
…2177) * adding IsMiddlewareEnabled flag to ActiveChannel genesis type * correcting yaml tag * adding changelog entry * Update proto/ibc/applications/interchain_accounts/genesis/v1/genesis.proto Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit b836b7f) # Conflicts: # CHANGELOG.md
colin-axner
added a commit
that referenced
this pull request
Sep 8, 2022
…backport #2177) (#2224) * chore: adding `IsMiddlewareEnabled` to `ActiveChannel` genesis type (#2177) * adding IsMiddlewareEnabled flag to ActiveChannel genesis type * correcting yaml tag * adding changelog entry * Update proto/ibc/applications/interchain_accounts/genesis/v1/genesis.proto Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit b836b7f) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2165
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes