Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding assertion of channel capabilities migration (backport #2140) #2219

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 7, 2022

This is an automatic backport of pull request #2140 done by Mergify.
Cherry-pick of 8d56b94 has failed:

On branch mergify/bp/release/v5.1.x/pr-2140
Your branch is up to date with 'origin/release/v5.1.x'.

You are currently cherry-picking commit 8d56b94.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   modules/apps/27-interchain-accounts/controller/keeper/migrations.go
	new file:   modules/apps/27-interchain-accounts/controller/keeper/migrations_test.go
	modified:   modules/apps/27-interchain-accounts/module.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* wip initial commit

* draft migration completed

* removing unnecessary storekey arg

* additional cleanup

* adding updates to migrations and tests additional assertions

* updating and moving migrations code

* adding additional checks to tests

* cleaning up tests

* cleaning up tests

* updating inline doc comments, checking err return

* using InitMemStore in favour of InitializeCapability, adjusting tests

* adding assertion of channel capabilities migration

* adapting migration code to use get/authenticate capability

* adding changelog

* updating tests

* set middleware enabled for existing channels

* assert middleware enabled in tests

* updating changelog with middleware enabled flag

(cherry picked from commit 8d56b94)

# Conflicts:
#	CHANGELOG.md
@damiannolan damiannolan merged commit c9090e2 into release/v5.1.x Sep 8, 2022
@damiannolan damiannolan deleted the mergify/bp/release/v5.1.x/pr-2140 branch September 8, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants