chore: update v6.0.x changelog #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
seantking,
charleenfei,
damiannolan and
chatton
as code owners
crodriguezvega
commented
Sep 11, 2022
CHANGELOG.md
Outdated
| * (apps/27-interchain-accounts) [\#2248](https://github.com/cosmos/ibc-go/pull/2248) Adding call to underlying app in `OnChanCloseConfirm` callback of the controller submodule and adding relevant unit tests. | ||
| * (apps/27-interchain-accounts) [\#2251](https://github.com/cosmos/ibc-go/pull/2251) Adding `msgServer` struct to controller submodule that embeds the `Keeper` struct. | ||
| * (apps/27-interchain-accounts) [\#2253](https://github.com/cosmos/ibc-go/pull/2253) Renaming `RegisterAccount` rpc to `RegisterInterchainAccount`, `MsgRegisterAccount` to `MsgRegisterInterchainAccount`, `MsgRegisterAccountResponse` to `MsgRegisterInterchainAccountResponse` and reordering fields of `MsgRegisterInterchainAccount` (`owner` comes before `connection_id`). | ||
| * (apps/27-interchain-accounts) [\#2255](https://github.com/cosmos/ibc-go/pull/2255) Renaming `SubmitTx` rpc to `SendTx`. |
There was a problem hiding this comment.
I think I should have opened this as a separate PR to main and then backport... Argh! If this PR is approved and merged, I will just copy then to main, if that's ok...
damiannolan
approved these changes
Sep 19, 2022
colin-axner
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RegisterAccountrpc and msgs toRegisterInterchainAccount#2253, chore: renameSubmitTxtoSendTx#2255.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes