Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm bech32 check from owner address on ICA controller msgs RegisterInterchainAccount and SendTx #2601

Merged
merged 7 commits into from
Oct 31, 2022
+0 −22
Merged

fix: rm bech32 check from owner address on ICA controller msgs RegisterInterchainAccount and SendTx #2601

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
353375c
rm validate basic owner address check
charleenfei Oct 26, 2022
f6d513d
rm bech32 check from registerICA
charleenfei Oct 26, 2022
23da000
Merge branch 'main' into charly/ica_owneraddress
charleenfei Oct 26, 2022
3fe4d41
Merge branch 'main' into charly/ica_owneraddress
charleenfei Oct 27, 2022
ad8047f
Merge branch 'main' into charly/ica_owneraddress
charleenfei Oct 27, 2022
1906fa7
Merge branch 'main' into charly/ica_owneraddress
Oct 29, 2022
09f1f1c
Merge branch 'main' into charly/ica_owneraddress
charleenfei Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions modules/apps/27-interchain-accounts/controller/types/msgs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ func (msg MsgRegisterInterchainAccount) ValidateBasic() error {
return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "owner address cannot be empty")
}

if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner)
}

return nil
}

Expand Down Expand Up @@ -68,10 +64,6 @@ func (msg MsgSendTx) ValidateBasic() error {
return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "owner address cannot be empty")
}

if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner)
}

if err := msg.PacketData.ValidateBasic(); err != nil {
return sdkerrors.Wrap(err, "invalid interchain account packet data")
}
Expand Down
14 changes: 0 additions & 14 deletions modules/apps/27-interchain-accounts/controller/types/msgs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,6 @@ func TestMsgRegisterInterchainAccountValidateBasic(t *testing.T) {
},
false,
},
{
"owner address is invalid",
func() {
msg.Owner = "invalid_address"
},
false,
},
}

for i, tc := range testCases {
Expand Down Expand Up @@ -124,13 +117,6 @@ func TestMsgSendTxValidateBasic(t *testing.T) {
},
false,
},
{
"owner address is invalid",
func() {
msg.Owner = "invalid_address"
},
false,
},
{
"relative timeout is not set",
func() {
Expand Down