Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: address ADR 8 review suggestions #3319

Merged
merged 8 commits into from
Mar 22, 2023
Merged

imp: address ADR 8 review suggestions #3319

merged 8 commits into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. chore: add adr 8 to architecture readme

    @colin-axner
    colin-axner committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    7f39d75 View commit details
    Browse the repository at this point in the history

  2. chore: apply review suggestion #1976 (comment)

    @colin-axner
    colin-axner committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f03761b View commit details
    Browse the repository at this point in the history

  3. chore: add reference and move requirement of implmenting callback int… 

    …erface reasoning to neutral section
    @colin-axner
    colin-axner committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    9c0624f View commit details
    Browse the repository at this point in the history

  4. imp: update ADR 8 documentation and code handling

    @colin-axner
    colin-axner committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8a690c9 View commit details
    Browse the repository at this point in the history

  5. fix: update pseudo code for OnAck and OnTimeout handling

    @colin-axner
    colin-axner committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    3e93505 View commit details
    Browse the repository at this point in the history

  6. chore: update godoc

    @colin-axner
    colin-axner committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    3176855 View commit details
    Browse the repository at this point in the history

  7. Update docs/architecture/adr-008-app-caller-cbs/adr-008-app-caller-cb… 

    …s.md

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    @colin-axner @damiannolan
    colin-axner and damiannolan authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    9b26da8 View commit details
    Browse the repository at this point in the history

  8. Update docs/architecture/adr-008-app-caller-cbs/adr-008-app-caller-cb… 

    …s.md

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    @colin-axner @damiannolan
    colin-axner and damiannolan authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ace9da9 View commit details
    Browse the repository at this point in the history