Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing query for next sequence send #3417

Merged
merged 10 commits into from
Apr 12, 2023

Conversation

expertdicer
Copy link
Contributor

Description

closes: #3383

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #3417 (549868a) into main (a18f96a) will decrease coverage by 0.06%.
The diff coverage is 60.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3417      +/-   ##
==========================================
- Coverage   78.59%   78.54%   -0.06%     
==========================================
  Files         181      181              
  Lines       12546    12581      +35     
==========================================
+ Hits         9861     9882      +21     
- Misses       2252     2265      +13     
- Partials      433      434       +1     
Impacted Files Coverage Δ
modules/core/04-channel/types/query.go 0.00% <0.00%> (ø)
modules/core/keeper/grpc_query.go 0.00% <0.00%> (ø)
modules/core/04-channel/keeper/grpc_query.go 84.55% <77.77%> (-0.49%) ⬇️

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @expertdicer. There are a few places where receive is used instead of send.

modules/core/04-channel/client/cli/query.go Outdated Show resolved Hide resolved
modules/core/04-channel/client/cli/query.go Outdated Show resolved Hide resolved
modules/core/04-channel/client/cli/query.go Show resolved Hide resolved
modules/core/04-channel/keeper/grpc_query.go Show resolved Hide resolved
modules/core/04-channel/keeper/grpc_query.go Outdated Show resolved Hide resolved
proto/ibc/core/channel/v1/query.proto Show resolved Hide resolved
modules/core/04-channel/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @expertdicer. I just realised there were a couple of other naming typos, but apart from that it looks good to me. I think we can ignore the lint warning receiver name k should be consistent with previous receiver name q for Keeper, since all the other receiver names will be renamed in a different PR.

proto/ibc/core/channel/v1/query.proto Outdated Show resolved Hide resolved
proto/ibc/core/channel/v1/query.proto Outdated Show resolved Hide resolved
proto/ibc/core/channel/v1/query.proto Outdated Show resolved Hide resolved
@expertdicer
Copy link
Contributor Author

Thanks, @expertdicer. I just realised there were a couple of other naming typos, but apart from that it looks good to me. I think we can ignore the lint warning receiver name k should be consistent with previous receiver name q for Keeper, since all the other receiver names will be renamed in a different PR.

I fixed the typos but I think there are typos in QueryNextSequenceReceive too. Should I fix it too ?

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR @expertdicer, very clean!

@crodriguezvega
Copy link
Contributor

I fixed the typos but I think there are typos in QueryNextSequenceReceive too. Should I fix it too ?

No, no need to fix those in this PR. :) We can do that in a follow-up.

@crodriguezvega
Copy link
Contributor

@expertdicer Just one more thing :) Could you run make format? Looks like on file needs to be gofumpted...

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crodriguezvega crodriguezvega merged commit 3a7106c into cosmos:main Apr 12, 2023
@expertdicer expertdicer deleted the nguyen/next-sequence-send branch April 12, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing query for next sequence send
5 participants