Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChanUpgradeTimeout
handler for 04-channel #3829ChanUpgradeTimeout
handler for 04-channel #3829Changes from 20 commits
50b1163
ba1fde4
8cd8c0b
392a5b5
0a363de
a227949
8b18b02
7b8b67b
760940b
106ac13
7f12c0b
29f84ce
16f196a
17748af
7341c5a
e9a2c20
900dcb6
8cf4a62
661f006
ba5e566
e3315ea
e1e7da7
de2607d
634b53e
6070c07
8fc3ee6
2df489c
065b003
5b9fa3e
470ee69
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to change the
prevErrorReceipt
to be of type*types.ErrorReceipt
. This would be more in line with the spec. There is no functional difference anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] to reduce indentation we can remove the else, and just add a
return nil
the line above this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idea: maybe we could also just call ChanUpgradeCancel here in this case, instead of forcing the user to call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.