Add hasInflightPackets. #3836
Merged
Add hasInflightPackets. #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
DimitrisJim
force-pushed
the
has_inflight_packets
branch
from
c335fcb
to
294d9ba
Compare
DimitrisJim
force-pushed
the
has_inflight_packets
branch
from
294d9ba
to
d854567
Compare
DimitrisJim
commented
Jun 13, 2023
| @@ -570,3 +570,14 @@ func (k Keeper) iterateHashes(ctx sdk.Context, iterator db.Iterator, cb func(por | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // hasInflightPackets returns true if there are packet commitments stored at the specified channel and | |||
There was a problem hiding this comment.
I think its small enough to be tested indirectly by the places that call it but can add it to export_test and write a small test for it.
chatton
approved these changes
Jun 14, 2023
charleenfei
approved these changes
Jun 14, 2023
crodriguezvega
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
hasInflightPacketsto the keeper. Used in both WriteUpgradeAckChannel and the handler for ChanUpgradeOpencloses: #3816
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.